mirrors/arti.git/crates/tor-proto/src/channel.rs, branch arti-v1.2.4 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.4 2024-05-29T11:16:19Z ChannelSender::poll_ready_unpin_bool: move to util 2024-05-29T11:16:19Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-05-29T11:15:39Z urn:sha1:237eb7a53f8953b8b6697ff110e1aec686b19d50 This is where it belongs. ChannelSender::poll_ready_unpin_bool: extension trait 2024-05-29T11:16:15Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-05-29T11:15:08Z urn:sha1:e0115adb172001a84867e98520341a0ad1b96628 This makes this available for any Sink + Unpin. Which we want because we're about to wrap our ChannelSender in a Sink wrapper. It's in the wrong place now; we'll move it in a moment. ChannelSender::poll_ready_unpin_bool: rename from poll_ready 2024-05-29T11:15:53Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-05-29T10:00:44Z urn:sha1:ca05a4dcb9979c6916cd1f0d7ccc74af433969e0 This would otherwise shadow the poll_ready method, which is confusing. Also this paves the way for making it available for any Sink + Unpin. Improve the docs somewhat to explain what this thing actually is. ChannelSender::poll_ready inherent method: Don't discard error 2024-05-29T09:53:55Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-05-29T09:44:14Z urn:sha1:71e28f8c47477c025ce0fd2375de8fbdfcdf85b4 I think this error was in fact always Error::CircuitClosed because it came from ChannelClosed.into(). Anyway, we shouldn't squash it. Now this function has semantics identical to Sink::poll_ready, just a slightly different signature. ChannelSender::poll_ready inherent method: Avoid apparent discard 2024-05-29T09:53:49Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-05-29T09:43:10Z urn:sha1:850ce5400a13d81abeb14f64c5ab5a85f583fc03 Make it clear we're discarding `()`, not an actual value. ChannelSender::poll_ready inherent method: Use Sink:poll_ready 2024-05-29T09:53:39Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-05-29T09:41:45Z urn:sha1:6d67dfc5af077eff34f2346b2780290be6d7ed47 We're going to change this function, but first we are going to make its behaviour identical to Sink::poll_ready. This avoids open-coding the call to poll_read on cell_tx. The error handling is still strange. We'll fix that in a moment. Remove an outdated comment. 2024-05-20T15:12:05Z Nick Mathewson nickm@torproject.org 2024-05-20T15:12:05Z urn:sha1:4ecd4c7c71119d79b971e21416f63f9dd71d70dd Make an arc clone explicit. 2024-05-20T15:10:18Z Nick Mathewson nickm@torproject.org 2024-05-20T15:10:18Z urn:sha1:aef0bd8a1ffcf36c021966daa4010594bf639f11 Fix a typo. 2024-05-20T15:06:35Z gabi-250 gabi@torproject.org 2024-05-20T15:06:35Z urn:sha1:f309609b26d6e88637bac4f025df2c3d72b9a29d proto: Divide up some elements of ChannelDetails. 2024-05-16T16:24:12Z Nick Mathewson nickm@torproject.org 2024-05-16T16:15:17Z urn:sha1:98dc42c3e0a4cfa9f5663b01ff27d085e725ca57 Previously ChannelDetails had a double duty: It held elements shared among the clones of a Channel, and it also held elements shared between the Channel and the Reactor. But now that Channel doesn't have to implement Clone, we can more the non-Reactor elements into Channel itself. This change may improve cache locality a bit, and should make it a little easier to follow the channel code. I've also moved unique_id out of ChannelDetails into Channel _and_ Reactor: it is small, immutable, and used all the time in logging.