mirrors/arti.git/crates/tor-proto/src/channel.rs, branch arti-v0.6.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.6.0 2022-06-21T19:34:27Z Merge branch 'display_source_cleanup' into 'main' 2022-06-21T19:34:27Z eta tor@eta.st 2022-06-21T19:34:27Z urn:sha1:4e3537746f4aa5d4df4abd5cb2be1385a4baa64b Do not include error source() in display() format. See merge request tpo/core/arti!598 channel padding: Rename ChannelsParams from ChannelsConfig (rustfmt) 2022-06-21T18:19:28Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-17T13:17:07Z urn:sha1:a2614729a4d87e163a21a0569917e0097acf311c Consequential ordering changes. channel padding: Rename ChannelsParams from ChannelsConfig 2022-06-21T18:19:28Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-17T13:16:21Z urn:sha1:7d676cde02c692f3800f05ff8195a500e974677c As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/586#note_2814276 Change names and comments and docs everywhere. tor-proto: Have Channel::reconfigure throw ChannelClosed 2022-06-21T18:19:28Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-16T17:24:30Z urn:sha1:65e6683b0bb104b8fb344edd6189835b2cdc6620 Addresses https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/586#note_2813567 tor-proto: err: Provide ChannelClosed as a separate unit error 2022-06-21T18:19:28Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-16T17:16:31Z urn:sha1:13ca24ba3ae5a17744355b26a1706bd5aaa07891 channel padding: Plumb settings from chanmgr 2022-06-21T18:19:22Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-14T14:42:23Z urn:sha1:7f3f42673816be8924395c9db26e55bee5c9c412 channel padding: Introduce ChannelsConfig and reconfigure facility 2022-06-21T18:19:22Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-14T14:42:10Z urn:sha1:b5218a0c0e3d57756def81b15635318d3154de3d Nothing geenrates config updates yet. channel padding timer: Allow creation without providing parameters yet 2022-06-21T18:19:22Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-13T16:17:55Z urn:sha1:e5f3215b954a0d9b79059373ac937fcbda98e973 It turns out that we are going to want this. channel padding: Make Parameters a pub struct with builder 2022-06-21T18:19:22Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-13T13:33:11Z urn:sha1:7135b7c4c7cb2669c10db27b6838ee946a26afca chanmgr is going to want to make one of these from a NetDir. Do not include error source() in display() format. 2022-06-21T18:14:14Z Nick Mathewson nickm@torproject.org 2022-06-21T18:14:14Z urn:sha1:08d9bbf33b9fff8aa33a823422aa4e323137be07 According to doc/Errors.md, and in keeping with current best practices, we should not include display an error's `source()` as part of that error's display method. Instead, we should let the caller decide to call source() and display that error in turn. Part of #323.