mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=tor-dirmgr-v0.5.1 2022-07-12T14:15:07Z 2022-07-12T14:15:07Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-07-12T14:15:07Z urn:sha1:f098b93d0a2163a576e766388403e473aa10590d `NoLock` is now a variant of `err::ErrorSource` but that is private. 2022-07-06T15:47:17Z Nick Mathewson nickm@torproject.org 2022-07-05T14:28:18Z urn:sha1:853aed685983a83e97c273f2135d23f09ff2bef0 Every error now has an action (what we were trying to do), a resource (what we were trying to do it to), and a source (what problem we encountered). Initially I tried to add "action" and "resource" fields to error variants individually, but that led to a combinatorial explosion. Part of #323. 2022-07-06T10:38:10Z Nick Mathewson nickm@torproject.org 2022-07-05T14:05:08Z urn:sha1:aeef36a5386faee95aa2279740ea5d05bef22547 2022-06-24T16:00:22Z Nick Mathewson nickm@torproject.org 2022-06-24T16:00:22Z urn:sha1:20435aea751331817709acde8d4b65b5fb8d8f12 These were done with the following commands: ``` cargo set-version -p tor-basic-utils --bump patch cargo set-version -p fs-mistrust --bump minor cargo set-version -p tor-error --bump patch cargo set-version -p tor-config --bump patch cargo set-version -p tor-units --bump patch cargo set-version -p tor-rtcompat --bump minor cargo set-version -p tor-llcrypto --bump patch cargo set-version -p tor-bytes --bump minor cargo set-version -p tor-socksproto --bump minor cargo set-version -p tor-cert --bump minor cargo set-version -p tor-cell --bump minor cargo set-version -p tor-proto --bump minor cargo set-version -p tor-netdoc --bump patch cargo set-version -p tor-netdir --bump minor cargo set-version -p tor-persist --bump patch cargo set-version -p tor-chanmgr --bump minor cargo set-version -p tor-guardmgr --bump minor cargo set-version -p tor-circmgr --bump patch cargo set-version -p tor-dirclient --bump patch cargo set-version -p tor-dirmgr --bump minor cargo set-version -p arti-client --bump patch cargo set-version -p arti --bump minor cargo set-version -p arti-bench --bump minor cargo set-version -p arti-testing --bump minor ``` 2022-06-23T18:15:42Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-23T18:15:29Z urn:sha1:589c6e52bb49ccfe6c0ad9d18d6b994978e46c6c Update all lint blocks 2022-06-22T19:21:34Z Nick Mathewson nickm@torproject.org 2022-06-22T19:21:34Z urn:sha1:813a648ce248e2f43fc4257562e7da09549a02ae 2022-06-22T12:03:15Z Nick Mathewson nickm@torproject.org 2022-06-21T19:13:03Z urn:sha1:326ab1a7aecfeed7b26d820c0b64d14b45ef9bef These changes make sure that the errors conform to our preferred style, and include a description of what exactly we were doing when something went wrong. 2022-06-15T15:52:30Z Nick Mathewson nickm@torproject.org 2022-06-14T18:52:39Z urn:sha1:647d4410bb263499f11f21a82ff6b414140e820d This is apparently a new warning from clippy nightly, documented in https://rust-lang.github.io/rust-clippy/master/index.html#significant_drop_in_scrutinee . I'm not in love with the temporary variables that this warning wants me to introduce, but it does seem like a decent way to avoid some kinds of deadlock. 2022-05-31T14:23:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-31T10:46:13Z urn:sha1:4f42101554822c44782c164cac0051e3b4055abd From running add_warning, with manual picking of the right hunks/lines. 2022-05-31T12:00:31Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-30T17:43:12Z urn:sha1:ba0843da4a7ba1e63846a286b870b893092e0a4f This was the result of: maint/add_warning crates/*/src/{lib,main}.rs and then manually curating the results.