mirrors/arti.git/crates/tor-persist/src, branch arti-v1.1.7 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.7 2023-07-10T12:49:51Z Run maint/add_warning to actually apply new lint allows 2023-07-10T12:49:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-10T11:19:32Z urn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0 Throughout: Use *_report!() macros for reporting Errors. 2023-07-07T17:00:21Z Nick Mathewson nickm@torproject.org 2023-07-07T13:54:27Z urn:sha1:25c6fe61e4cf230210dffdac2d3c281fcb31c5a9 I identified the cases to replace by searching for the string `.report()`. There are a few that I didn't change: * A couple of cases that used anyhow::Error, * One case that reported two Errors. * Two cases in `tor_hsclient::err` that just did `error!("Bug: {}")`. I have also not audited the cases in `tor-hsclient` where we're using `tor_error::Report` manually. Nonetheless, closes #949. Run add_warning to remove `missing_panics_doc` deny. 2023-07-06T18:32:23Z Nick Mathewson nickm@torproject.org 2023-07-06T18:32:23Z urn:sha1:03f9f9987a7ba42368d82363bef7f569e32ffe2c Closes #950. lints: Run maint/add_warning to actually apply new lints 2023-06-21T11:15:41Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-06-21T10:29:46Z urn:sha1:161b9844dae0aaa2e63bbc77c512d061be6bb390 Merge branch 'shadykaty-error-hint-v2' into 'main' 2023-02-07T16:32:10Z eta tor@eta.st 2023-02-07T16:32:10Z urn:sha1:85ca3e41b945cdcefb5241ef697476a80e578d03 Create and use an ErrorHint type to report how to fix a problem. Closes #579 and #578 See merge request tpo/core/arti!994 Use ErrorReport - run rustfmt 2023-01-30T18:52:32Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-01-30T18:51:16Z urn:sha1:37edcd688a63cd91a4652720d7d9fb66cc7efab1 Split off for ease of review and possible rebase. Use ErrorReport for errors in warn! in tor-persist 2023-01-30T18:52:32Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-01-30T18:21:31Z urn:sha1:47e226293f8647fbe588904d1b8fe957ff496deb ErrorHint: Implement tryfrom_torpersist 2023-01-27T16:56:53Z Nick Mathewson nickm@torproject.org 2023-01-27T16:35:27Z urn:sha1:39ad97fdc2ecd7693feb7ead8793926d3618191d Allow clippy::unchecked_duration_subtraction in tests 2023-01-27T13:28:02Z Nick Mathewson nickm@torproject.org 2023-01-27T13:01:45Z urn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada This panics on error, and we're fine with a panic on misbehavior in tests. Disable clippy::unlinlined-format-args 2023-01-27T13:27:47Z Nick Mathewson nickm@torproject.org 2023-01-27T12:49:39Z urn:sha1:bf04641c6818cb2c87c6ed9cf463a5710f8919d2 This warning kind of snuck up on us! (See #748) For now, let's disable it. (I've cleaned it up in a couple of examples, since those are meant to be more idiomatic and user-facing.) Closes #748.