mirrors/arti.git/crates/tor-persist/src, branch arti-v1.1.12 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.12 2023-12-13T17:02:45Z tor-persist: Provide FsMistrustErrorExt, and use it 2023-12-13T17:02:45Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-12-07T16:18:32Z urn:sha1:76bd3c0f4dc5886dbc4a11304a87661d1252b829 This code needs fs_mistrust::Error and tor_error::ErrorKind. I think we probably don't want fs_mistrust to depend on tor_error or vice versa. tor_persist is approximately the place where these two threads of thought come together, and it's currently the lowest place where this is needed. Use it in tor-dirmgr too, which is currently the other place that embodies this knowledge about fs_mistrust::Error. tor-persist: Make LockStatus #[must_use] 2023-11-22T12:58:06Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-11-22T12:57:03Z urn:sha1:641baaf7b65e5fb30f7215261084bccdf82997cf I see other problems with this API, see #1136. but we can at least easily do this. Run maint/add_warning to add lint block everywhere 2023-08-23T09:34:00Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-22T14:28:12Z urn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9ac Run add_warnings on all files. 2023-08-04T11:45:04Z Nick Mathewson nickm@torproject.org 2023-08-04T11:45:04Z urn:sha1:cec6d0ce33b4b5cebbce57f55faec83397e9c953 Run maint/add_warning to actually apply new lint allows 2023-07-10T12:49:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-10T11:19:32Z urn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0 Throughout: Use *_report!() macros for reporting Errors. 2023-07-07T17:00:21Z Nick Mathewson nickm@torproject.org 2023-07-07T13:54:27Z urn:sha1:25c6fe61e4cf230210dffdac2d3c281fcb31c5a9 I identified the cases to replace by searching for the string `.report()`. There are a few that I didn't change: * A couple of cases that used anyhow::Error, * One case that reported two Errors. * Two cases in `tor_hsclient::err` that just did `error!("Bug: {}")`. I have also not audited the cases in `tor-hsclient` where we're using `tor_error::Report` manually. Nonetheless, closes #949. Run add_warning to remove `missing_panics_doc` deny. 2023-07-06T18:32:23Z Nick Mathewson nickm@torproject.org 2023-07-06T18:32:23Z urn:sha1:03f9f9987a7ba42368d82363bef7f569e32ffe2c Closes #950. lints: Run maint/add_warning to actually apply new lints 2023-06-21T11:15:41Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-06-21T10:29:46Z urn:sha1:161b9844dae0aaa2e63bbc77c512d061be6bb390 Merge branch 'shadykaty-error-hint-v2' into 'main' 2023-02-07T16:32:10Z eta tor@eta.st 2023-02-07T16:32:10Z urn:sha1:85ca3e41b945cdcefb5241ef697476a80e578d03 Create and use an ErrorHint type to report how to fix a problem. Closes #579 and #578 See merge request tpo/core/arti!994 Use ErrorReport - run rustfmt 2023-01-30T18:52:32Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-01-30T18:51:16Z urn:sha1:37edcd688a63cd91a4652720d7d9fb66cc7efab1 Split off for ease of review and possible rebase.