mirrors/arti.git/crates/tor-persist/src/fs/clean.rs, branch main mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=main 2026-06-09T15:36:01Z maint: Run maint/add_warning to deny string slices 2026-06-09T15:36:01Z Clara Engler cve@cve.cx 2026-06-09T15:36:01Z urn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97 This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit. tor-persist: migrate to web-time-compat. 2026-03-26T19:20:16Z Nick Mathewson nickm@torproject.org 2026-03-26T13:59:32Z urn:sha1:ea9c1b13e0ab3a3b2c303636366d622bde65ddda Fix name of clippy lint to unchecked_time_subtraction (2) 2025-11-06T11:28:22Z Ian Jackson ijackson@chiark.greenend.org.uk 2025-11-06T11:23:25Z urn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff Run maint/add_warning tor-persist: miri: disable tests that involve fs access 2024-10-08T15:53:28Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-10-07T12:14:27Z urn:sha1:9e9ab427948a3b7fed7b19b17715c4d67fda9682 Run maint/add_warning. 2024-03-13T16:30:53Z Nick Mathewson nickm@torproject.org 2024-03-13T16:30:53Z urn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320c Use tor_basic_utils::PathExt::display_lossy 2024-03-05T15:34:29Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-03-04T19:23:09Z urn:sha1:418d4c588839eb116666b29ba03cc5bf262d3d71 Change Path::display to this new function, in call sites where it's being used for a diagnostic. Run maint/add_warning to add lint block everywhere 2023-08-23T09:34:00Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-22T14:28:12Z urn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9ac Run maint/add_warning to actually apply new lint allows 2023-07-10T12:49:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-10T11:19:32Z urn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0 Throughout: Use *_report!() macros for reporting Errors. 2023-07-07T17:00:21Z Nick Mathewson nickm@torproject.org 2023-07-07T13:54:27Z urn:sha1:25c6fe61e4cf230210dffdac2d3c281fcb31c5a9 I identified the cases to replace by searching for the string `.report()`. There are a few that I didn't change: * A couple of cases that used anyhow::Error, * One case that reported two Errors. * Two cases in `tor_hsclient::err` that just did `error!("Bug: {}")`. I have also not audited the cases in `tor-hsclient` where we're using `tor_error::Report` manually. Nonetheless, closes #949. Use ErrorReport for errors in warn! in tor-persist 2023-01-30T18:52:32Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-01-30T18:21:31Z urn:sha1:47e226293f8647fbe588904d1b8fe957ff496deb