mirrors/arti.git/crates/tor-persist/src/fs.rs, branch arti-v1.2.4mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.42024-03-13T16:30:53ZRun maint/add_warning.2024-03-13T16:30:53ZNick Mathewsonnickm@torproject.org2024-03-13T16:30:53Zurn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320ctor-persist: Improve test portability2024-03-01T12:56:54ZTobias Stoeckmanntobias@stoeckmann.org2024-03-01T10:51:14Zurn:sha1:0f882658e2bf2d4fc218de559871be812f8c6951
The test fails on Windows systems for two reasons:
- File separator \ is printed in error message instead of expected /
- Temporary files are located within home directory, which is anonymized
Test failure can be provoked on Linux as well by setting TMPDIR to point
to a directory within HOME.
tor-persist: Provide load_store module for use by state_dir2024-01-24T16:29:19ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-24T11:45:04Zurn:sha1:d2d1cc31f76c20c165a5c16cbc774b0e0f6d9297tor-persist: Use correct pathnames in errors2024-01-24T16:29:19ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-24T11:39:59Zurn:sha1:9905dc0652de20b6bb02c5138c450c440e0f2c30
Before this, we would say the problem happened while accessing
Resource::File {
container: "STATE_DIR",
file: "KEY.json",
}
which would imply that we failed to access "STATE_DIR/KEY.json".
But that's not true: we *actually* access "STATE_DIR/state/KEY.json".
Run maint/add_warning to add lint block everywhere2023-08-23T09:34:00ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-22T14:28:12Zurn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9acRun maint/add_warning to actually apply new lint allows2023-07-10T12:49:51ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-10T11:19:32Zurn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0Throughout: Use *_report!() macros for reporting Errors.2023-07-07T17:00:21ZNick Mathewsonnickm@torproject.org2023-07-07T13:54:27Zurn:sha1:25c6fe61e4cf230210dffdac2d3c281fcb31c5a9
I identified the cases to replace by searching for the string
`.report()`. There are a few that I didn't change:
* A couple of cases that used anyhow::Error,
* One case that reported two Errors.
* Two cases in `tor_hsclient::err` that just did
`error!("Bug: {}")`.
I have also not audited the cases in `tor-hsclient` where we're using
`tor_error::Report` manually.
Nonetheless, closes #949.
Use ErrorReport - run rustfmt2023-01-30T18:52:32ZIan Jacksonijackson@chiark.greenend.org.uk2023-01-30T18:51:16Zurn:sha1:37edcd688a63cd91a4652720d7d9fb66cc7efab1
Split off for ease of review and possible rebase.
Use ErrorReport for errors in warn! in tor-persist2023-01-30T18:52:32ZIan Jacksonijackson@chiark.greenend.org.uk2023-01-30T18:21:31Zurn:sha1:47e226293f8647fbe588904d1b8fe957ff496debAllow clippy::unchecked_duration_subtraction in tests2023-01-27T13:28:02ZNick Mathewsonnickm@torproject.org2023-01-27T13:01:45Zurn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada
This panics on error, and we're fine with a panic on misbehavior in
tests.