mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.0.1 2022-10-03T13:52:34Z 2022-10-03T13:52:34Z Nick Mathewson nickm@torproject.org 2022-10-03T13:52:34Z urn:sha1:388e0cbab55490f41e1c8cd06631efed7f23a318 2022-09-30T13:00:42Z Nick Mathewson nickm@torproject.org 2022-09-30T13:00:42Z urn:sha1:6a04188d59e2bd2365340b60643c91d4b9c78e9b The warning `clippy::bool_to_int_with_if` is meant to shout at you when you say `if x { 1 } else { 0 }` and instead suggest that you say `inttype::from(x)`. I agreed with this for the case in tor-cert, where we are literally converting a boolean into a flag. I don't agree with this in tor-netdoc, where we are using a boolean to decide how many fields to skip in a given document format. So for this case, I decided to clean up the code a little by renaming "skip" to "n_skip", and changing the boolean to use an enum instead. 2022-09-26T15:23:21Z Nick Mathewson nickm@torproject.org 2022-09-26T13:17:37Z urn:sha1:571e7f9556adf12de8c8189ddbfc78c78a534a74 Their omission was an oversight. 2022-09-01T12:59:49Z Nick Mathewson nickm@torproject.org 2022-09-01T12:52:51Z urn:sha1:96875ea20875e3a5cfc9f348365f19a158578190 Because we want to work more on ensuring that our semver stability story is solid, we are _not_ bumping arti-client to 1.0.0 right now. Here are the bumps we _are_ doing. Crates with "minor" bumps have had API breaks; crates with "patch" bumps have had new APIs added. Note that `tor-congestion` is not bumped here: it's a new crate, and hasn't been published before. ``` tor-basic-utils minor fs-mistrust minor tor-config minor tor-rtcompat minor tor-rtmock minor tor-llcrypto patch tor-bytes patch tor-linkspec minor tor-cell minor tor-proto minor tor-netdoc patch tor-netdir minor tor-persist patch tor-chanmgr minor tor-guardmgr minor tor-circmgr minor tor-dirmgr minor arti-client minor arti-hyper minor arti major arti-bench minor arti-testing minor ``` 2022-08-24T16:22:41Z trinity-1686a trinity@deuxfleurs.fr 2022-08-18T00:24:22Z urn:sha1:ca99e9f63587fcf8164b813f4ca265507002ea53 2022-08-24T16:22:41Z trinity-1686a trinity@deuxfleurs.fr 2022-08-18T00:04:46Z urn:sha1:426a59b2ba591e20a13c568d665310c55e2f8e53 2022-08-24T16:22:41Z trinity-1686a trinity@deuxfleurs.fr 2022-08-17T19:13:13Z urn:sha1:7f939fa4804b3c934343141b79e8e2ded5fe0b0d 2022-08-16T17:43:23Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-07-25T15:48:43Z urn:sha1:cd8d41fd2e04d1a6d4876324707cad2035ac001d Otherwise a caller who has a set of parameters must open-code the loop. 2022-08-01T13:56:29Z Nick Mathewson nickm@torproject.org 2022-08-01T13:56:29Z urn:sha1:859ae4acd00dc63ee3d903b21eb34f9267377185 Do _not_ bump the dependency versions on crates that have had no changes since arti 0.0.5, since those crates do not depend on the new APIs. ``` cargo set-version -p tor-basic-utils --bump patch cargo set-version -p tor-llcrypto --bump patch git restore crates/tor-checkable git restore crates/tor-consdiff git restore crates/tor-rtmock ``` 2022-08-01T13:49:13Z Nick Mathewson nickm@torproject.org 2022-08-01T13:47:52Z urn:sha1:511cb469977778f1aad964de93b9e49b56d43ed2 This performs the transitive closure of the last operation: everything that depends on a crate with a breaking change gets the version which it depends on bumped. ``` cargo set-version -p tor-proto --bump minor cargo set-version -p tor-netdoc --bump minor cargo set-version -p arti-hyper --bump minor cargo set-version -p arti-bench --bump minor cargo set-version -p arti-testing --bump minor cargo set-version -p tor-config --bump minor ```