mirrors/arti.git/crates/tor-netdoc/src, branch arti-v1.2.8

Upgrade to derive_more version 1.0.0

2024-09-25T14:37:18Z

The `derive_more` crate broke backward compatibility with this version, so this change involved quite a few manual fixups. With luck, they'll keep compatibility for some while in the future.

tor-circmgr: Remove AbstractSpec and FakeSpec.

2024-09-16T14:57:33Z

AbstractSpec and FakeSpec actually make testing more difficult, since they prevent using FakeBuilder in code that relies on the concrete TargetCircUsage and SupportedCircUsage types. Removing them means FakeBuilder can be used in more places, and also means that the test code is closer to the real code, since TargetCircUsage and SupportedCircUsage are now exercised directly in more tests. This did require making one change to a test, which I think was previously testing behaviour that was true for FakeSpec but not for the real code: The mgr::test::isolated test previously asserted that, in the case where three circuits were requested, two with isolation and one without, the non-isolated circuit would be shared with one of the isolated circuits. This was allowed by the FakeSpec::supports function. However, in the actual code, the path is as follows: * AbstractCircMgr::get_or_launch * AbstractCircMgr::prepare_action * CircList::find_open * AbstractSpec::find_supported * abstract_spec_find_supported * OpenEntry::supports * SupportedCircUsage::supports * StreamIsolation::compatible_same_type StreamIsolation::compatible_same_type checks owner_type, which is always zero for non-isolated streams and always non-zero for isolated streams, meaning that a isolated stream will never be compatible with a non-isolated stream. The seems like desirable behaviour, so I simply modified the test to make four connections, two isolated and two not, and checked that the isolated streams never share any circuits, and that the two non-isolated streams use the same circuit. As far as I can tell, this is the intended behaviour in the existing code.

tor-netdoc: impl `Extend` on `NetParams`

2024-09-03T22:23:08Z

Resolve unreachable_patterns warnings from nightly.

2024-08-13T13:30:42Z

Nightly rust doesn't like it when you have a `match` arm that can never be reached because of an uninhabited type. As such, we can't say stuff like: ``` let x: Option = ...; match x { Some(_) => unreachable!(), None => ... } ```

Fix "clippy::manual-pattern-char-comparison" warning on nightly

2024-07-28T21:48:35Z

This warning suggests using `[a,b]` as a Pattern when it sees a search for `|ch| ch == a || ch == b`. (All of our supported rust versions allow this kind of Pattern.)

Merge branch 'expose-annotated' into 'main'

2024-07-22T18:34:44Z

tor-netdoc: Dangerously expose annotation fields Closes #1469 See merge request tpo/core/arti!2213

Fix clippy::doc_lazy_continuation

2024-07-08T10:36:25Z

Make TAP keys optional when parsing documents.

2024-06-27T13:57:11Z

This is the client-side part of phase 1 for proposal 350, which will eventually remove TAP completely from the Tor network.

tor-netdoc: Dangerously expose annotation fields

2024-06-21T11:43:47Z

This commit exposes the fields of `routerdesc::AnnotatedRouterDesc` and `routerdesc::RouterAnnotation` with the enabled feature `dangerous-expose-struct-fields`. On one side, it achieves a greater consistency among the other structures found within this module; On the other side it makes the already public API (assuming the feature above is enabled) useable. Fixes #1469

Add exception for cfg(fuzzing) in tor-netdoc

2024-05-07T15:35:55Z

The use of cfg(fuzzing) here is reasonable and localized, but we need to permit it to avoid a warning from #1395.