mirrors/arti.git/crates/tor-netdoc/src, branch arti-v1.1.3

Merge branch 'fix-broken-doc-links' into 'main'

2023-03-30T19:12:01Z

Fix broken doc link. See merge request tpo/core/arti!1082

Remove hard-coded test certs.

2023-03-27T18:44:49Z

We can use a deterministic rng to generate predictable keypairs instead. Signed-off-by: Gabriela Moldovan

Make the HS encoder randomness source injectable.

2023-03-27T18:07:41Z

This makes it possible to plug in a deterministic randomness source for testing. Signed-off-by: Gabriela Moldovan

Fix broken doc link.

2023-03-27T12:29:24Z

This fixes a broken doc link I introduced in !1070: ``` error: unresolved link to `crate::doc::hsdesc::build::inner::HsDescInnerBuilder` --> crates/tor-netdoc/src/doc/hsdesc/build/middle.rs:34:11 | 34 | /// [`crate::doc::hsdesc::build::inner::HsDescInnerBuilder`] as described in sections | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `HsDescInnerBuilder` in module `inner` | = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings` error: could not document `tor-netdoc` ``` Signed-off-by: Gabriela Moldovan

Use the type system to enforce use of blinded keys.

2023-03-27T10:45:51Z

Hidden services use blinded singing keys derived from the identity key to sign descriptor signing keys. Before this patch, the hidden descriptor builder represented its blinded signing keys (`blinded_id`) as plain `ed25519::Keypair`s. This was not ideal, as there was nothing preventing the caller from accidentally initializing `blinded_id` with an unblinded keypair. This introduces a new `HsBlindKeypair` type to represent blinded keypairs. Signed-off-by: Gabriela Moldovan

Use transparent structs instead of builders.

2023-03-24T18:58:34Z

The consensus seems to be the builders don't add much value, see [this comment]. [this comment]: https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1070#note_2889488 Signed-off-by: Gabriela Moldovan

Refactor the inner doc tests to be more DRY.

2023-03-24T18:58:34Z

Signed-off-by: Gabriela Moldovan

Remove `NetdocText` and replace its uses with `String`.

2023-03-24T18:58:34Z

`NetdocText` is a wrapper around a `String` and a type marker. The type annotation proved of limited use, and made the netdoc builder API somewhat awkward to use. Signed-off-by: Gabriela Moldovan

Remove some unnecessary visibility restrictions.

2023-03-24T18:58:34Z

Signed-off-by: Gabriela Moldovan

Create a new `IntroPointDesc` type.

2023-03-24T18:58:33Z

Unlike `hsdesc::IntroPointDesc`, `hsdesc::build::IntroPointDesc` represents link specifiers as `LinkSpec`s rather than `UnparsedLinkSpec`s. Since this is a general-purpose representation of an introduction point and not merely an intermediate representation for decoding/encoding, it will probably need to be factored out of `tor-netdoc` at some point. Signed-off-by: Gabriela Moldovan