mirrors/arti.git/crates/tor-netdoc/src/parse, branch derive-traits mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=derive-traits 2022-02-14T18:08:28Z Refactor tor_netdoc::Error 2022-02-14T18:08:28Z Nick Mathewson nickm@torproject.org 2022-02-14T18:08:28Z urn:sha1:b6d23c36bef1322e4fc6f89769222daa91c4d8f3 This error type doesn't impement HasKind, since the kind will depend on context. However, the existing implementation was pretty messy and inconsistent: Some errors had positions, some didn't. Some took messages as str, some as String. Some had internal errors that were somewhat orthogonal to their actual types. This commit refactors tor_netdoc::Error to use a ParseErrorKind, and adds a set of convenience functions to add positions and messages to the errors that need them. clippy: Suppress a warning 2022-01-19T17:12:26Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-01-19T17:12:26Z urn:sha1:5e16a52e1c657e95e889a7a4db54d3d417cfb6df Change an UTF-8 XXX to a TODO. 2021-12-20T14:54:41Z Nick Mathewson nickm@torproject.org 2021-12-20T14:54:41Z urn:sha1:a2afb29806b62d702668431672e75fdc5778547b We're assuming that prop285 is accepted in some form. address lint warnings 2021-12-09T13:06:32Z Daniel Eades danieleades@hotmail.com 2021-12-09T12:10:23Z urn:sha1:2bcd7b6d78c0cab47b9e6b1adba21b0d7120c17f [Edited by nickm: This applies one of Daniel's fixes in place of one of Trinity's: Trinity says it's a bit cleaner, and I agree.] fix nightly clippy errors 2021-12-09T11:16:23Z Trinity Pointard trinity.pointard@gmail.com 2021-12-09T11:16:23Z urn:sha1:9753a7ee06d1dad9b9dbaa1653593bb545d4cf59 add semicolons if nothing returned 2021-11-25T13:20:37Z Daniel Eades danieleades@hotmail.com 2021-11-25T13:14:05Z urn:sha1:db16d13df4779ac61005050dfe5ce05e3d5a1b5d tor-netdoc: Put the "routerdesc" document type behind a feature. 2021-11-12T17:15:30Z Nick Mathewson nickm@torproject.org 2021-11-12T16:19:33Z urn:sha1:7b12b54d407580f8574975f5c7e864d65d986dd0 Nothing in arti currently uses this document type. Eventually it will be useful for relays and for bridge clients. I've left the "SHA1 digest of a router descriptor" type available unconditinoally, however, since it does get used in a few places. Part of #125. Fix/suppress a few more clippy lints in tests. 2021-09-08T18:20:47Z Nick Mathewson nickm@torproject.org 2021-09-08T18:20:47Z urn:sha1:ab0c80de2ba210f189207c535db6454ef6d179c6 I'm alright with allowing cognitive-complexity violations in the tests. fix/silence clippy lints in test modules 2021-09-08T15:28:31Z Daniel Eades danieleades@hotmail.com 2021-08-30T07:52:16Z urn:sha1:fb3b8b84b5709ebe8a29051c43b82c4eef85decc Move all crates into a `crates` subdirectory. 2021-08-27T13:53:09Z Nick Mathewson nickm@torproject.org 2021-08-27T13:53:09Z urn:sha1:557a0ff40b3731d4690767de27010bbeff08777d This will cause some pain for now, but now is really the best time to do this kind of thing.