mirrors/arti.git/crates/tor-netdoc/src/parse, branch arti-v2.5.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.0 2026-06-11T13:39:46Z tor-netdoc: Expose MaybeItem::pos pub(crate) 2026-06-11T13:39:46Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-06-02T19:18:42Z urn:sha1:ddddd5084b47bedda3b5addb8f98919fe9378cd8 everywhere: Add #[allow(clippy::string_slice)] 2026-06-09T16:02:36Z Clara Engler cve@cve.cx 2026-06-09T16:00:38Z urn:sha1:d0af4abbd7b371f1eade609202a730cd9a1c21d3 This commit adds #[allow(clippy::string_slice)] to all functions in the code where string slices are used, alongside a TODO comment. We do this add the function header to have it consistent, as things like expression based allow's are still experimental. maint: Run maint/add_warning to deny string slices 2026-06-09T15:36:01Z Clara Engler cve@cve.cx 2026-06-09T15:36:01Z urn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97 This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit. tor-netdoc: Un-gate "routerdesc" cargo feature 2026-04-28T13:58:19Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-28T13:28:52Z urn:sha1:562b2d7bd0779725994b318ff5b31e08b78f7c10 As per #2492. tor-netdoc: Un-gate BASE64_PEM_MAX_LINE 2026-04-23T14:40:11Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-23T14:39:58Z urn:sha1:42b563bc56b37148ad5efea3bfa950ab764c2f36 tor-netdoc: Add a blank line for reading clarity 2025-11-18T20:58:17Z Ian Jackson ijackson@chiark.greenend.org.uk 2025-11-18T13:20:31Z urn:sha1:46239f2d58f11fe7e56aee53a10b89c78fe99575 As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3471#note_3288716 tor-netdoc: Split off Keyword::to_str into its own trait (fmt) 2025-11-18T20:58:03Z Ian Jackson ijackson@chiark.greenend.org.uk 2025-11-17T17:44:36Z urn:sha1:39d9fef00e8239cd8929860ffdf96932ab182de7 tor-netdoc: Split off Keyword::to_str into its own trait 2025-11-18T20:58:03Z Ian Jackson ijackson@chiark.greenend.org.uk 2025-11-17T16:22:03Z urn:sha1:ff88c5886866ae3cdb52f33773a41a8049a7b5cd My planned encoding derive macro is not going to use `decl_keyword!` but will need to call `NetdocEncoder::item`. tor-netdoc: Split off Keyword::to_str - prep code motion 2025-11-18T20:58:03Z Ian Jackson ijackson@chiark.greenend.org.uk 2025-11-17T15:54:48Z urn:sha1:35ce846909b05716e4c31b419cd94ab70190c8a3 tor-netdoc: Keyword: Say that to_str is the actual document keyword 2025-11-18T20:58:03Z Ian Jackson ijackson@chiark.greenend.org.uk 2025-11-17T15:47:50Z urn:sha1:c58300aead1e3d52204117935346537bcc509213 NetdocEncoder::item uses it this way. Presumably it is right at least in those cases where this method is called. The only implementor of this trait right now is the output from `decl_keyword!` in the old parser, which is (generally) expected to be the actual keyword.