mirrors/arti.git/crates/tor-netdoc/src/parse, branch arti-v1.1.0

Fix a couple of rustdoc issues.

2022-11-18T15:19:54Z

These slipped in while nightly was broken.

Fix a bunch of "needless borrow" warnings on nightly

2022-11-18T15:12:05Z

It looks like, despite a few false starts, they've got this warning right; there weren't any false positives.

Replace `Option` with `Pos` in `ParseError`.

2022-11-15T21:58:23Z

We already have `Pos::Unknown` for an error at an unknown location and `Pos::None` for an error where no location is sensible. There's no reason to have an additional `Option` here. Additionally, the use of `Option` gave us a bug where our old `ParseError::at_pos()` method didn't actually set the position unless the position was already set. That's not what we want! Fixes #640. Finally, we have to fix a test that was a bit broken because it was working around #640.

Resolve a dead-code warning.

2022-11-15T18:53:14Z

netdoc: Allow empty lines at the end of a router descriptor.

2022-11-15T16:27:43Z

tor-netdoc: Add a new ErrorKind for EmptyLine.

2022-11-15T16:27:43Z

Empty lines were previously reported as BadKeyword, which is confusing.

Fix some rustdoc errors.

2022-10-13T13:08:46Z

In addition to the usual "You named that method wrong!" errors, we have a new rustdoc error that complains about bogus "HTML tags" that are actually unquoted usage of types like `Result`.

Replace `base64` crate with `base64ct` crate

2022-06-22T01:02:33Z

Note: the `base64ct` crate rejects invalid characters when the decoding is done on padded strings. However, the `FromStr` impl for `B64` can have both padded **and** unpadded inputs, so all inputs are now padded first, before decoding.

Add one more "allow" to tor_netdoc::parse::macros.

2022-06-15T15:52:30Z

Without this, clippy is error-free, but `cargo test` somehow gives a warning.

Netdoc: test enforcement for items that mustn't take objects.

2022-06-07T16:45:57Z

Found via coverage.