mirrors/arti.git/crates/tor-netdoc/src/parse, branch arti-v0.3.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.3.02022-03-11T18:42:01Ztor-netdoc: Actually, make TokVal be a Vec2022-03-11T18:42:01ZIan Jacksonijackson@chiark.greenend.org.uk2022-03-11T18:42:01Zurn:sha1:888eea47b3ee03c28411c4abcc5eeca8b4088e40
This enum was otiose: its set of valid values is precisely those of a
Vec. (Indeed what would TokVal::Multi(vec![]) have meant?)
Remove a pointless slice2022-03-11T18:24:03ZIan Jacksonijackson@chiark.greenend.org.uk2022-03-11T18:17:58Zurn:sha1:9a7783a230f8c5df007220ecb5ff9d2486cbb2a6
std::slice::from_ref exists. Spotted while reviewing !400
Refactor tor_netdoc::Error2022-02-14T18:08:28ZNick Mathewsonnickm@torproject.org2022-02-14T18:08:28Zurn:sha1:b6d23c36bef1322e4fc6f89769222daa91c4d8f3
This error type doesn't impement HasKind, since the kind will depend
on context.
However, the existing implementation was pretty messy and inconsistent:
Some errors had positions, some didn't.
Some took messages as str, some as String.
Some had internal errors that were somewhat orthogonal to their actual
types.
This commit refactors tor_netdoc::Error to use a ParseErrorKind, and
adds a set of convenience functions to add positions and
messages to the errors that need them.
clippy: Suppress a warning2022-01-19T17:12:26ZIan Jacksonijackson@chiark.greenend.org.uk2022-01-19T17:12:26Zurn:sha1:5e16a52e1c657e95e889a7a4db54d3d417cfb6dfChange an UTF-8 XXX to a TODO.2021-12-20T14:54:41ZNick Mathewsonnickm@torproject.org2021-12-20T14:54:41Zurn:sha1:a2afb29806b62d702668431672e75fdc5778547b
We're assuming that prop285 is accepted in some form.
address lint warnings2021-12-09T13:06:32ZDaniel Eadesdanieleades@hotmail.com2021-12-09T12:10:23Zurn:sha1:2bcd7b6d78c0cab47b9e6b1adba21b0d7120c17f
[Edited by nickm: This applies one of Daniel's fixes in place of one
of Trinity's: Trinity says it's a bit cleaner, and I agree.]
fix nightly clippy errors2021-12-09T11:16:23ZTrinity Pointardtrinity.pointard@gmail.com2021-12-09T11:16:23Zurn:sha1:9753a7ee06d1dad9b9dbaa1653593bb545d4cf59add semicolons if nothing returned2021-11-25T13:20:37ZDaniel Eadesdanieleades@hotmail.com2021-11-25T13:14:05Zurn:sha1:db16d13df4779ac61005050dfe5ce05e3d5a1b5dtor-netdoc: Put the "routerdesc" document type behind a feature.2021-11-12T17:15:30ZNick Mathewsonnickm@torproject.org2021-11-12T16:19:33Zurn:sha1:7b12b54d407580f8574975f5c7e864d65d986dd0
Nothing in arti currently uses this document type. Eventually it
will be useful for relays and for bridge clients.
I've left the "SHA1 digest of a router descriptor" type available
unconditinoally, however, since it does get used in a few places.
Part of #125.
Fix/suppress a few more clippy lints in tests.2021-09-08T18:20:47ZNick Mathewsonnickm@torproject.org2021-09-08T18:20:47Zurn:sha1:ab0c80de2ba210f189207c535db6454ef6d179c6
I'm alright with allowing cognitive-complexity violations in the
tests.