mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.3.0 2026-04-29T10:38:37Z 2026-04-29T10:38:37Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-29T10:28:02Z urn:sha1:3d1f272aab1c4815bef932c09efa5e12ed318a9c We want DirectorySignatureHashAlgo for prod's directory Signature type. However, for complex cfg gate and macro scoping reasons, we can't just move the definition out of poc. Hence this rather unpleasant intermediate state. This will go away, and become normal again, when we can abolish poc's signatures and have poc use a prod signature type. Review with git show --color=always --color-moved-ws=allow-indentation-change --color-moved 2026-04-29T10:20:28Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-27T15:13:12Z urn:sha1:24b773c0074d68b7ee6771d3652c7e3794a46130 2026-04-29T10:20:28Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-27T14:43:55Z urn:sha1:4c75ba0cb8c036e4b330f1f10740e7c29e8379de This allows implementing NormalItemArgument for types that can only be parsed, or only displayed - or other combinations. I noticed this restriction while inventing a type I later decided was unnecessary. I still think it's a good change. There is no practical impact elsewhere, since in practice downstream code implements NormalItemArgument rather than relying on it. 2026-04-27T16:57:21Z Clara Engler cve@cve.cx 2026-04-27T16:57:21Z urn:sha1:ce062efb711a8db0161db8ddb4d06e0996e95e05 tor-netdoc: Parsing and encoding for netstatus authority sections See merge request tpo/core/arti!3892 2026-04-27T15:49:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-15T14:26:21Z urn:sha1:221c0bf0c7f041fc84c60c8a844fac34da7d5fe5 Replace poc code with new ConsensusAuthoritySection. This is an entirely new parsing approach. Key differences: * We parse the arguments to dir-source, which poc didn't. * We don't clone the input and fully parse the first item; instead, we dismantle the dir-source line ad-hoc to determine the item type. * Rather than a Vec of Enums, we parse into two Vecs of the different entry types. The few lines that aren't rewritten show up as moved in git show --color-moved --color-moved-ws=allow-indentation-change but I suggest reviewing the new implementation de novo. 2026-04-27T15:49:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-27T15:47:15Z urn:sha1:1df2d81bc074542bdaf3648a2329939927a30faa Almost entirely code motion. Review with --color-moved. This is new correct for votes, and uses the non-poc names for things. We'll improve up a few minor things in a moment. The cfg situation is getting very tangled. There are already various TODOs about this. I think it is time to bite the bullet; I will do that separately from this MR. 2026-04-27T15:48:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-15T15:16:00Z urn:sha1:f0dd308815e9f8c85f648556417d8b58ae67b846 Prepare for the namespace environment in the mainline doc/netstatus modules. (Add a couple of temporary use's.) 2026-04-27T15:48:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-15T15:11:36Z urn:sha1:5c15e2f124edd8b52ad94bdfe996a4b13ee33290 We are going to move this code to the main doc/netstatus modules. Rename the struct and its associated derive macro, to the naming approach used outside poc. We leave a `use` behind in poc. That can remain until poc is eventually abolished. 2026-04-27T15:48:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-14T17:28:07Z urn:sha1:6aa3a12f92dd15030050f8670c17300a44463b36 Purely whitespace change: deindent certain lines by 4. `git show -w` is helpful. 2026-04-27T15:48:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-13T10:50:47Z urn:sha1:7f5462ee11ddfeb614d87ff75f9496638e8e5e2d This has a side effect of testing the parsing. (Testing of the encoding will have to come a lot later.)