mirrors/arti.git/crates/tor-netdoc/src/parse2, branch arti-v1.9.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.9.02026-01-06T11:05:34Ztor-netdoc: RSA: check exponent and min size in parse22026-01-06T11:05:34ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-16T18:05:41Zurn:sha1:005597bb298a7da32a28ac61e624ef522a0d9703
According to the spec we always use this fixed exponent, and we have a
minimum size of 1024. This is checked adhoc in the old parser with
some slight assistance from what is now `RsaPublicParse1Helper`.
It's not clear to me that checking the exponent is actually a good
idea. I think checking the size is probably a bad idea, and if it is
a good idea then 1024 is clearly too short.
But rather than revisit these questions, let's reproduce the old
behaviour in parse2.
In parse2 these checks should be features of the type.
tor-netdoc: Break out and expose ItemStream::byte_position2025-12-18T17:28:36ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-17T15:52:29Zurn:sha1:98e2b2e3eb692a82ba8b599635e76531270fdd3btor-netdoc: Use $P for prelude in one place2025-12-18T16:44:55ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-10T14:38:46Zurn:sha1:5ec68ca2391068f90683fc406fb6f38bd4074050
This was missed, apparently.
tor-netdoc: Add two TODOs re trait naming2025-12-10T11:05:28ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-09T17:01:38Zurn:sha1:c21970fb5cb8d165370e6a33a48d7fd4e64c4d01tor-netdoc: derive netdoc encoding traits2025-12-10T11:05:28ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-08T12:30:03Zurn:sha1:d101894ca656906c4d6ddb3cb82f31aae4970a72
Signature encoding is not yet supported. We need to consider how this
will work.
tor-netdoc: debug: Add a placeholder debug print to all the other derives2025-12-10T11:05:28ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-08T16:30:18Zurn:sha1:1751e36a78eb7bc10be080d1fd10a30f855f9098
We want to recognise `#[deftly(netdoc(debug))]` because otherwise we
have to make lots of these attributes conditional.
So, implement it for *all* the derives, providing a nugatory debug
statement.
tor-netdoc: parse2: debug: Explain why we use io::stderr()2025-12-10T11:05:28ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-08T16:01:53Zurn:sha1:9eae46408025bc7944a0eb39fedab6aa82f7c727tor-netdoc: parse2: debug: Fix an error message2025-12-10T11:05:28ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-08T15:59:20Zurn:sha1:d54d32bcd0388ad00e182b029e2c77b41164694c
What is being written to here is StderrLock, not a String.
tor-netdoc: parse2: debug: Fix scoping of netdoc_parseable_derive_debug2025-12-10T11:05:28ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-08T15:59:13Zurn:sha1:85d2b11bc579be30d244ef0d65d6169bf0f5ea4e
While testing I discovered that the `#[deftly(netdoc(debug))]`
feature (which dumps parsing progress to stderr) didn't compile if the
derive was invoked from elsewhere.
tor-netdoc: derive_common: Break out docs for attrs in flatten2025-12-10T11:05:28ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-08T14:15:54Zurn:sha1:136ae84c9228c8b65f535f3bf7f3ffde0bafaeee
Code motion fromk NetdocParseableFields to NetdocFieldsDeriveCommon.
This uses the derive-deftly imported doc comment feature.