mirrors/arti.git/crates/tor-netdoc/src/parse2/signatures.rs, branch mainmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=main2026-06-10T14:42:10Ztor-netdoc: parse2: Deprecate check_validity_time2026-06-10T14:42:10ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-10T10:55:24Zurn:sha1:ee0f46c2d90249359087d6f594bd9dcd872f7b75
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/4070#note_3422637
We must allow it in poc, but poc is a thing we're trying to
abolish/replace, so that's OK.
tor-netdoc: Rename NetdocUnverified trait to NetdocParseableUnverified2026-06-02T10:39:51ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-02T10:32:02Zurn:sha1:9b014fc0c02be35576fde6cb927e7c9645b5f827
The NetdocParseableUnverified derive macro implements this
trait (amongst other things). Traits and derive macros should have
aligned names.
This is only used for parsing, so let's keep the "Parseable" part of
the name.
I don't think the effort of deprecated alias, for downstream
compatibility, is worth it, our compatibility policy notwithstanding.
tor-netdoc: parse2/encode derive: Show unquoted attributes in the docs2026-04-07T16:05:05ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-02T09:22:24Zurn:sha1:05dcb0091730ffc3de33b96fd99a72fb0ded99e1tor-netdoc: signature orderliness: add some xrefs2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-18T16:21:52Zurn:sha1:2a01b25ccd5e4ef3f9cfd2ed3b2c6e1bfe4d032ctor-netdoc: signature orderliness: orderly signs don't cover other sigs2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-18T16:19:54Zurn:sha1:d9c643e7869b0543c8b72483a58a5707d22d3d94
This is implied by `body` being the body before the first signature
item, but needs to be part of the definition.
tor-netdoc: signature orderliness: shuffle wording slightly2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-18T16:19:35Zurn:sha1:4ee19211be41365f6121be9981037967eaa52306tor-netdoc: signature orderliness: change terminology2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-18T16:18:19Zurn:sha1:7108314102c3e1f41b146a4c8e2d69e2727ea538
"Regular" is confusing, especially since in American English it tends
to mean "usual" - whereas, there are no orderly signatures in Tor
netdocs.
tor-netdoc: parse2: Include body length in SignaturesData2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-10T18:03:31Zurn:sha1:3b363ca3f616dc2e7242a3206d495a12a0dace4c
This could allow users to attach and detach signatures, hash (only)
the body part, etc.
tor-netdoc: parse2: Don't impl NetdocParseable for bodies of signed docs2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-11T12:24:55Zurn:sha1:5e5dc10f0f4d477bf0e8e4d2197610c149a59541
Such an impl is a footgun. Explain this in docs & comments.
tor-netdoc: parse2: Unify top-level derive as NetdocUParseablenverified2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-09T17:48:49Zurn:sha1:575261d3f0c6f537640ecbe810396aac35652de2
Replace the two separate NetdocParseable and NetdocUnverified derives,
for toplevel signed documents, with a single derive.
This makes the derive API simpler. It will also make it reasonably
possible to avoid deriving NetdocParseable directly for body structs.
Such impls are a security hazard!
In detail:
* Rename NetdocUnverified to NetdocParseableUnverified
* Have it use $IMPL_NETDOC_PARSEABLE from the NetdocParseable deftly
module so that it derives NetdocParseable for the body.
(We'll change this later in the series.)
* Adjust the docs and all call sites.