mirrors/arti.git/crates/tor-netdoc/src/parse2/poc, branch arti-v2.5.0

tor-netdoc: votes: use EmbeddedCert for the authhcert

2026-06-17T10:30:15Z

tor-netdoc: tests: Move ns poc tests to netstatus.rs

2026-06-17T09:33:17Z

We're going to turn these into full-on round-trip tests for both flavours of consensus. We must temporarily bodge the more comprehensive test, for plain con sensuses, to to still use the actual document type from poc. That allows us to avoid changing the arguments to verify() etc. (poc's verify is subtly different to the real NetworkStatus's.) When these tests were in poc, they were gated by the incomplete cfg on the whole of poc. Now they have one each. Almost entirely code motion; review with git show --color-moved --color-moved-ws=allow-indentation-change

tor-netdoc: tests: Move poc authcert test to authcert.rs

2026-06-17T09:33:17Z

There is no separate poc authcert type any more. This is a perfectly fine test case. Almost entirely code motion; review with git show --color-moved --color-moved-ws=allow-indentation-change

tor-netdoc: poc tests: drop some unneeded &'s

2026-06-17T09:33:17Z

clippy complains (clippy::needless_borrows_for_generic_args). In poc, we have an allow with a TODO asking for this to be done generally in the Arti codebase. Let's postpone shaving that yak.

tor-netdoc: poc tests: use normal names for authcerts

2026-06-17T09:33:17Z

tor-netdoc: poc tests: simulate normal outside-poc variety module names

2026-06-17T09:33:17Z

We are going to reuse/move this test code. Ie, it is going to be testing the real network document types. The naming outside poc is different. To make future diffs a bit less noisy, change some type names in the test code and fudge it up with a use.

tor-netdoc: Rename variants in VerifyGeneralTrustedAuthorities

2026-06-11T17:49:04Z

In a wip branch I added a variant, and clippy complained. In this case, I agree with clippy. warning: all variants have the same postfix: `Authorities` --> crates/tor-netdoc/src/doc/netstatus.rs:2335:1 | 2335 | / pub(crate) enum VerifyGeneralTrustedAuthorities<'r> { 2336 | | /// Trust these authorities. 2337 | | TrustTheseAuthorities { 2338 | | /// The HKP_auth_id_rsa ... | 2357 | | }, 2358 | | } | |_^ | = help: remove the postfixes and use full paths to the variants instead of glob imports = help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#enum_variant_names note: the lint level is defined here --> crates/tor-netdoc/src/lib.rs:9:9 | 9 | #![warn(clippy::all)] | ^^^^^^^^^^^ = note: `#[warn(clippy::enum_variant_names)]` implied by `#[warn(clippy::all)]`

tor-netdoc: consensuses: Introduce VerifyGeneralTrustedAuthorities (fmt)

2026-06-11T16:55:52Z

tor-netdoc: consensuses: Introduce VerifyGeneralTrustedAuthorities

2026-06-11T16:55:52Z

This avoids passing the threshold around as a bare usize, separated out from the list of trusted authorities. Roughly as discussed in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/4065#note_3423775 But, VGTA::HazardouslyAssumeAllAuthCertsAreRealAuthorities contains n_authorities, not the thtreshold. That's what its user has, and that allows us to centralise the threshold calculation somewhat. The situation with votes in poc is a bit odd now: we pass one cert and then there's one authority so the threshold of 1 is calculated rather than literal. That's OK, but also we perhaps aren't going to use verify_general for votes in the production.

tor-netdoc: Apply deferred rustfmt import churn

2026-06-11T16:55:52Z