mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.4.0 2026-05-27T12:43:10Z 2026-05-27T12:43:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-05-12T20:00:19Z urn:sha1:785e7cd9676de48a9102bf314aa11f29b9972717 Replacing poc's. The new define_fixed_string macro is really helping here. 2026-05-27T12:43:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-05-12T20:20:16Z urn:sha1:bfa47db273bede961d4ac14426fb3e4c0c5f48a2 Defining a struct gives us a place to hang the documentation, and avoids an accidentally-exhaustive tuple. 2026-05-27T12:43:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-05-12T10:09:20Z urn:sha1:1f8919e69927bd5227755892c56ce623bec7f671 This is more code than the poc version but much of the extra is documentation, and it seems much less magical this way. We still need a handwritten parser for plain consensuses, sadly. 2026-05-27T12:43:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-05-12T11:26:32Z urn:sha1:c4ed766e476cb029e48ac878a42cae04cb23a2e4 The order of arguments of poc's ns_type macro is different to that of the real code. This is very confusing! However, the type is correct, once we've added the singleton signature for votes. 2026-05-27T12:43:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-05-11T15:14:10Z urn:sha1:9b87534fd9e1cbc1ff88e255217ef96fe36168c2 This is the whole of the footer section, with docs, appropriate derives, and so on. 2026-04-27T15:49:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-15T14:26:21Z urn:sha1:221c0bf0c7f041fc84c60c8a844fac34da7d5fe5 Replace poc code with new ConsensusAuthoritySection. This is an entirely new parsing approach. Key differences: * We parse the arguments to dir-source, which poc didn't. * We don't clone the input and fully parse the first item; instead, we dismantle the dir-source line ad-hoc to determine the item type. * Rather than a Vec of Enums, we parse into two Vecs of the different entry types. The few lines that aren't rewritten show up as moved in git show --color-moved --color-moved-ws=allow-indentation-change but I suggest reviewing the new implementation de novo. 2026-04-27T15:49:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-27T15:47:15Z urn:sha1:1df2d81bc074542bdaf3648a2329939927a30faa Almost entirely code motion. Review with --color-moved. This is new correct for votes, and uses the non-poc names for things. We'll improve up a few minor things in a moment. The cfg situation is getting very tangled. There are already various TODOs about this. I think it is time to bite the bullet; I will do that separately from this MR. 2026-04-27T15:48:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-15T15:16:00Z urn:sha1:f0dd308815e9f8c85f648556417d8b58ae67b846 Prepare for the namespace environment in the mainline doc/netstatus modules. (Add a couple of temporary use's.) 2026-04-27T15:48:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-15T15:11:36Z urn:sha1:5c15e2f124edd8b52ad94bdfe996a4b13ee33290 We are going to move this code to the main doc/netstatus modules. Rename the struct and its associated derive macro, to the naming approach used outside poc. We leave a `use` behind in poc. That can remain until poc is eventually abolished. 2026-04-27T15:48:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-14T17:28:07Z urn:sha1:6aa3a12f92dd15030050f8670c17300a44463b36 Purely whitespace change: deindent certain lines by 4. `git show -w` is helpful.