mirrors/arti.git/crates/tor-netdoc/src/parse2/poc/netstatus, branch arti-v2.3.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.3.02026-04-27T15:49:05Ztor-netdoc: consensus authority section: ConsensusAuthoritySection2026-04-27T15:49:05ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-15T14:26:21Zurn:sha1:221c0bf0c7f041fc84c60c8a844fac34da7d5fe5
Replace poc code with new ConsensusAuthoritySection.
This is an entirely new parsing approach.
Key differences:
* We parse the arguments to dir-source, which poc didn't.
* We don't clone the input and fully parse the first item; instead,
we dismantle the dir-source line ad-hoc to determine the item type.
* Rather than a Vec of Enums, we parse into two Vecs
of the different entry types.
The few lines that aren't rewritten show up as moved in
git show --color-moved --color-moved-ws=allow-indentation-change
but I suggest reviewing the new implementation de novo.
tor-netdoc: VoteAuthoritySection: promote poc to prod2026-04-27T15:49:05ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-27T15:47:15Zurn:sha1:1df2d81bc074542bdaf3648a2329939927a30faa
Almost entirely code motion. Review with --color-moved.
This is new correct for votes, and uses the non-poc names for things.
We'll improve up a few minor things in a moment.
The cfg situation is getting very tangled. There are already various
TODOs about this. I think it is time to bite the bullet; I will do
that separately from this MR.
tor-netdoc: VoteAuthoritySection: promote poc to prod (prep, use's)2026-04-27T15:48:52ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-15T15:16:00Zurn:sha1:f0dd308815e9f8c85f648556417d8b58ae67b846
Prepare for the namespace environment in the mainline doc/netstatus
modules. (Add a couple of temporary use's.)
tor-netdoc: VoteAuthoritySection: promote poc to prod (prep, rename)2026-04-27T15:48:52ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-15T15:11:36Zurn:sha1:5c15e2f124edd8b52ad94bdfe996a4b13ee33290
We are going to move this code to the main doc/netstatus modules.
Rename the struct and its associated derive macro, to the naming
approach used outside poc.
We leave a `use` behind in poc. That can remain until poc is
eventually abolished.
tor-netdoc: VoteAuthoritySection: deindent NddAuthoritySection2026-04-27T15:48:52ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-14T17:28:07Zurn:sha1:6aa3a12f92dd15030050f8670c17300a44463b36
Purely whitespace change: deindent certain lines by 4.
`git show -w` is helpful.
tor-netdoc: VoteAuthorityEntry: replace in poc with new proper type2026-04-27T15:48:52ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-13T10:50:47Zurn:sha1:7f5462ee11ddfeb614d87ff75f9496638e8e5e2d
This has a side effect of testing the parsing.
(Testing of the encoding will have to come a lot later.)
tor-netdoc: parse2/encode derive: Use meta_quoted rigorous2026-04-07T16:05:05ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-02T10:03:02Zurn:sha1:faae49236a4669b6d177b3b8626c31ba45b513ee
The `doctype_for_error` attribute needs immediate adjustment, because
a string expression value is expected. With `quoted retain`, that
would be re-interpreted, silently. This kind of thing is why
`quoted rigorous` exists.
So change its docs and the one use site.
The macros' docs, and the other calls ites, we'll deal with shortly.
tor-netdoc: Abolish poc::authcert2026-04-01T11:32:17ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-01T10:05:56Zurn:sha1:884df9a2f0184db8b0b8f4c784b4cb5843d50dc9
This was just some type aliases. Put them in the poc files that used
them. (These type aliases are undesirable but we aren't cleaning them
up because the whole of poc is destined for deletion.)
tor-netdoc: Fix typo in doc comment2026-03-31T18:13:58ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-30T10:56:10Zurn:sha1:bb5c908facf18ec5a1faaac7fa2bb0f8b8bd21e8Fix typos2026-03-24T16:04:08ZTobias Stoeckmanntobias@stoeckmann.org2026-03-24T16:04:08Zurn:sha1:1fb2b8dd4aee7c943ce90d6631be473f2a296fe6
Typos found with codespell