mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.2.0 2026-03-24T16:04:08Z 2026-03-24T16:04:08Z Tobias Stoeckmann tobias@stoeckmann.org 2026-03-24T16:04:08Z urn:sha1:1fb2b8dd4aee7c943ce90d6631be473f2a296fe6 Typos found with codespell 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-09T17:48:49Z urn:sha1:575261d3f0c6f537640ecbe810396aac35652de2 Replace the two separate NetdocParseable and NetdocUnverified derives, for toplevel signed documents, with a single derive. This makes the derive API simpler. It will also make it reasonably possible to avoid deriving NetdocParseable directly for body structs. Such impls are a security hazard! In detail: * Rename NetdocUnverified to NetdocParseableUnverified * Have it use $IMPL_NETDOC_PARSEABLE from the NetdocParseable deftly module so that it derives NetdocParseable for the body. (We'll change this later in the series.) * Adjust the docs and all call sites. 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-11T13:06:35Z urn:sha1:aefa48e251f514a2cdbcb9e4a26292438b74af68 During encoding, including these hashes in the signature items makes no sense. The hashes are an *input* to the signature items, but not part of them. Move the hashes out of the items. Instead, provide each signatures section type with a hash accumulator type, in which the hash(es) are stored. 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-03T19:24:42Z urn:sha1:399c09200a008b02f4a9551fed22032feacf198d This is going to contain body information, and the hashes, too. 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-03T19:04:43Z urn:sha1:e12328a78e03425465320d98ad695c00614dac8d This is going to be its own trait and it is usually best if macros are named after traits, rather than having the macro derive a different trait depending on meta attributes. 2026-03-03T18:56:01Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-03T18:46:00Z urn:sha1:9018c73d34ca60c5f671eeafc540446864998941 This was a weird name, and while working in this area it all seemed to make the docs strange. Rename it. This is quite invasive! In theory we could have the macros generate compatibility aliases, but that seems quite complex. 2026-01-15T13:28:44Z Ian Jackson iwj@torproject.org 2026-01-15T13:28:44Z urn:sha1:d654fbd34967f3bed1bb58816f2603d0a817f3ca Implement EncodedAuthCert and use it in poc for votes See merge request tpo/core/arti!3592 2026-01-15T12:37:09Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-01-14T16:35:47Z urn:sha1:cf99f6959268372768d73c87b97affc1cc2161c9 2026-01-15T12:37:09Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-01-12T17:42:11Z urn:sha1:3892195d3b944474f5fd73336aa213104ff71b52 Roughly as per the proposal in `doc/dev/notes/authcert-in-consensus.md`. 2026-01-15T12:37:09Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-01-14T15:46:14Z urn:sha1:50e8eaa1f8f8012bc41ad4bfbffa15e3a97647d6 We can use the real AuthCert now that it implements the parse2 traits. The verification function is still used by poc's netstatus code and by a test case. We must change the field names in a few places, because the real AuthCert's struct field names are the keywords, whereas the poc's are the key names. (A shame that they're different!)