mirrors/arti.git/crates/tor-netdoc/src/parse2/poc/netstatus.rs, branch arti-v2.5.0

tor-netdoc: Rename variants in VerifyGeneralTrustedAuthorities

2026-06-11T17:49:04Z

In a wip branch I added a variant, and clippy complained. In this case, I agree with clippy. warning: all variants have the same postfix: `Authorities` --> crates/tor-netdoc/src/doc/netstatus.rs:2335:1 | 2335 | / pub(crate) enum VerifyGeneralTrustedAuthorities<'r> { 2336 | | /// Trust these authorities. 2337 | | TrustTheseAuthorities { 2338 | | /// The HKP_auth_id_rsa ... | 2357 | | }, 2358 | | } | |_^ | = help: remove the postfixes and use full paths to the variants instead of glob imports = help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#enum_variant_names note: the lint level is defined here --> crates/tor-netdoc/src/lib.rs:9:9 | 9 | #![warn(clippy::all)] | ^^^^^^^^^^^ = note: `#[warn(clippy::enum_variant_names)]` implied by `#[warn(clippy::all)]`

tor-netdoc: consensuses: Introduce VerifyGeneralTrustedAuthorities (fmt)

2026-06-11T16:55:52Z

tor-netdoc: consensuses: Introduce VerifyGeneralTrustedAuthorities

2026-06-11T16:55:52Z

This avoids passing the threshold around as a bare usize, separated out from the list of trusted authorities. Roughly as discussed in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/4065#note_3423775 But, VGTA::HazardouslyAssumeAllAuthCertsAreRealAuthorities contains n_authorities, not the thtreshold. That's what its user has, and that allows us to centralise the threshold calculation somewhat. The situation with votes in poc is a bit odd now: we pass one cert and then there's one authority so the threshold of 1 is calculated rather than literal. That's OK, but also we perhaps aren't going to use verify_general for votes in the production.

tor-netdoc: Apply deferred rustfmt import churn

2026-06-11T16:55:52Z

tor-netdoc: ns verification: Allow "dry run" to just get missing certs info

2026-06-11T16:55:52Z

No functional change with the existing caller.

tor-netdoc: ns verification: verify_general, return Result

2026-06-11T16:55:52Z

No functional change.

tor-netdoc: poc: Abolish core of separate verification logic

2026-06-11T16:55:21Z

In an attempt to check that the new verification code makes sense, we compare it with the freshly rewritten one in poc. To review this, compare the code being deleted with the body of verify_general (doc/netstatus.rs, line 2164 et seq). You'll also want to refer to the body of find_cert and check_signature (lines 2068-2086).

tor-netdoc: poc: Skip duplicate signatures earlier.

2026-06-11T16:55:20Z

Like verify_general does. (This wasn't a bug before, because we could the length of ok, so all that would happen is we'd do some extra work.)

tor-netdoc: poc: Reorder slightly

2026-06-11T16:55:20Z

Obtain the hash first, like verify_general does. No significant functional change, and this is poc code anyway.

tor-netdoc: poc: Use let else continue (fmt)

2026-06-11T16:55:20Z