mirrors/arti.git/crates/tor-netdoc/src/parse2/poc/netstatus.rs, branch arti-v2.4.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.4.02026-05-27T12:43:10Ztor-netdoc: introduce VoteStatusConsensus and VoteStatusVote2026-05-27T12:43:10ZIan Jacksonijackson@chiark.greenend.org.uk2026-05-12T20:00:19Zurn:sha1:785e7cd9676de48a9102bf314aa11f29b9972717
Replacing poc's. The new define_fixed_string macro is really helping
here.
tor-netdoc: NetworkStatusVersionItem, replacing poc's tuple2026-05-27T12:43:10ZIan Jacksonijackson@chiark.greenend.org.uk2026-05-12T20:20:16Zurn:sha1:bfa47db273bede961d4ac14426fb3e4c0c5f48a2
Defining a struct gives us a place to hang the documentation, and
avoids an accidentally-exhaustive tuple.
tor-netdoc: NetworkStatusVersion, replacing poc's with FixedString2026-05-27T12:43:09ZIan Jacksonijackson@chiark.greenend.org.uk2026-05-12T19:33:08Zurn:sha1:ae3016c5d8f2a8d1fed3beebb1af17d10b58c3d5tor-netdoc: Apply deferred rustfmt churn2026-04-29T17:48:03ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-29T17:24:16Zurn:sha1:1153b25ffc98ec8cddf61fc5c03f0a896587bce7tor-netdoc: Fix signature of hash_slice_for_verification2026-04-29T17:48:03ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-29T16:30:36Zurn:sha1:038c01aa4ba8501b8d107a27ccfd577ccf3a4ac4
In order to handle marked vs unmarked SHA1 correctly, it needs the
original DigestAlgoInSignature.
The only call site is in poc's verification code.
tor-netdoc: Abolish poc's netstatus signature type2026-04-29T17:48:03ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-29T16:15:34Zurn:sha1:f33cdcf44c4654e7043f7e93baa05eb7318ab005
Use prod's Signature instead.
This gets rid of:
* The old parsing code. We have a new approach based on
ItemValueParseable, KeywordOrString and and DigestAlgoInSignature.
* The duplicate DirectorySignaturesHashesAccu and its temporary conversions.
poc's verify_timeless function needs a little adjustment for the new
struct layout.
tor-netdoc: Promote hash_slice_for_verification to prod2026-04-29T16:40:54ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-29T16:15:30Zurn:sha1:8bcf8d44f085f268ae21c1c69cb1cf026dd27dee
This function is not right, yet. We're going to fix it later.
Review with --color-moved.
tor-netdoc: Introduce DirectorySignaturesHashesAccu::update_from2026-04-29T16:40:54ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-29T16:08:52Zurn:sha1:5aa7b82f5ec8469981226ff7dcfebb39fb846013
This now contains the hashing code that was in poc.
In poc it was entangled with the signature type, mostly because once
upon a time the hash was inside the signature.
In the real code we can make it a standalone method. It takes
DigestAlgoInSignature so that it will be able to handle the explicit
vs implicit sha1 anomaly correctly - but it can't do that yet because
the necessary field doesn't exist yet.
Also, we are going to want to make it a bit lazier - preserve the
MR-blocking todo for that.
A handful of lines are being actually moved verbatim,
so --color-moved may help a bit.
tor-netdoc: Promote poc's DirectorySignaturesHashesAccu to prod2026-04-29T16:33:39ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-29T15:53:11Zurn:sha1:ea5d42d936c841836dfda5050ec905be517b919b
There are definitely some things wrong with this, but they all have
MR-blocking TODOs so we can promote this type now.
Largely code motion. Review with --color-moved.
tor-netdoc: Make some items temporarily pub(crate)2026-04-29T16:33:39ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-29T14:38:49Zurn:sha1:d46bbe7bb4cbb27cff6f2198b0de06941968401d