mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.3.0 2026-04-29T10:38:37Z 2026-04-29T10:38:37Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-29T10:28:02Z urn:sha1:3d1f272aab1c4815bef932c09efa5e12ed318a9c We want DirectorySignatureHashAlgo for prod's directory Signature type. However, for complex cfg gate and macro scoping reasons, we can't just move the definition out of poc. Hence this rather unpleasant intermediate state. This will go away, and become normal again, when we can abolish poc's signatures and have poc use a prod signature type. Review with git show --color=always --color-moved-ws=allow-indentation-change --color-moved 2026-04-29T10:20:28Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-27T15:13:12Z urn:sha1:24b773c0074d68b7ee6771d3652c7e3794a46130 2026-04-27T15:49:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-15T14:26:21Z urn:sha1:221c0bf0c7f041fc84c60c8a844fac34da7d5fe5 Replace poc code with new ConsensusAuthoritySection. This is an entirely new parsing approach. Key differences: * We parse the arguments to dir-source, which poc didn't. * We don't clone the input and fully parse the first item; instead, we dismantle the dir-source line ad-hoc to determine the item type. * Rather than a Vec of Enums, we parse into two Vecs of the different entry types. The few lines that aren't rewritten show up as moved in git show --color-moved --color-moved-ws=allow-indentation-change but I suggest reviewing the new implementation de novo. 2026-04-27T15:49:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-27T15:47:15Z urn:sha1:1df2d81bc074542bdaf3648a2329939927a30faa Almost entirely code motion. Review with --color-moved. This is new correct for votes, and uses the non-poc names for things. We'll improve up a few minor things in a moment. The cfg situation is getting very tangled. There are already various TODOs about this. I think it is time to bite the bullet; I will do that separately from this MR. 2026-04-27T15:48:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-15T15:16:00Z urn:sha1:f0dd308815e9f8c85f648556417d8b58ae67b846 Prepare for the namespace environment in the mainline doc/netstatus modules. (Add a couple of temporary use's.) 2026-04-27T15:48:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-13T10:50:47Z urn:sha1:7f5462ee11ddfeb614d87ff75f9496638e8e5e2d This has a side effect of testing the parsing. (Testing of the encoding will have to come a lot later.) 2026-04-01T11:32:17Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-01T10:05:56Z urn:sha1:884df9a2f0184db8b0b8f4c784b4cb5843d50dc9 This was just some type aliases. Put them in the poc files that used them. (These type aliases are undesirable but we aren't cleaning them up because the whole of poc is destined for deletion.) 2026-03-24T16:04:08Z Tobias Stoeckmann tobias@stoeckmann.org 2026-03-24T16:04:08Z urn:sha1:1fb2b8dd4aee7c943ce90d6631be473f2a296fe6 Typos found with codespell 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-11T11:59:16Z urn:sha1:7b72ea8cfbc3cee531e1397fe8bcfbd804ba252f Run rustfmt and selectively apply the hunks that are relevant to the previous commit. 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-11T13:06:35Z urn:sha1:aefa48e251f514a2cdbcb9e4a26292438b74af68 During encoding, including these hashes in the signature items makes no sense. The hashes are an *input* to the signature items, but not part of them. Move the hashes out of the items. Instead, provide each signatures section type with a hash accumulator type, in which the hash(es) are stored.