mirrors/arti.git/crates/tor-netdoc/src/parse2/internal_prelude.rs, branch arti-v2.3.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.3.0 2026-03-19T10:37:47Z tor-netdoc: Apply deferred rustfmt churn to imports 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-11T12:59:17Z urn:sha1:9427eca66096a2a333fafb360532a3679dc52fd9 tor-netdoc: parse2: Don't impl NetdocParseable for bodies of signed docs 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-11T12:24:55Z urn:sha1:5e5dc10f0f4d477bf0e8e4d2197610c149a59541 Such an impl is a footgun. Explain this in docs & comments. tor-netdoc: parse2: Move hash out of signature items 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-11T13:06:35Z urn:sha1:aefa48e251f514a2cdbcb9e4a26292438b74af68 During encoding, including these hashes in the signature items makes no sense. The hashes are an *input* to the signature items, but not part of them. Move the hashes out of the items. Instead, provide each signatures section type with a hash accumulator type, in which the hash(es) are stored. tor-netdoc: parse2: Introduce SignatureData struct 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-03T19:24:42Z urn:sha1:399c09200a008b02f4a9551fed22032feacf198d This is going to contain body information, and the hashes, too. tor-netdoc: NetdocParseableSignatures: Make into its own trait 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-03T19:08:33Z urn:sha1:785576835464aa7737e06d0088f377548df0e62b tor-netdoc: Apply rustfmt churn 2026-03-03T18:57:38Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-03T18:57:38Z urn:sha1:96114eb9a68ca1c8062bc3f8761aee90115e003d tor-netdoc: parse2: Use eprint for dtrace 2026-03-03T18:56:29Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-03T18:03:27Z urn:sha1:479ca8e50d8973fbf76647976aeaa37baa87c708 tor-netdoc: Rename *Signed to *Unverified 2026-03-03T18:56:01Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-03T18:46:00Z urn:sha1:9018c73d34ca60c5f671eeafc540446864998941 This was a weird name, and while working in this area it all seemed to make the docs strange. Rename it. This is quite invasive! In theory we could have the macros generate compatibility aliases, but that seems quite complex. tor-netdoc: Move NetdocSigned to signatures.rs 2026-03-03T18:53:21Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-03T18:45:21Z urn:sha1:a465848cbb09f602075bd6c7c3c7444d224a6f43 I keep not finding it because all the other signatures stuff is in signatures.rs. tor-netdoc: parse2: Provide NetdocParseable::is_structural_keyword (rustfmt) 2026-01-15T12:37:09Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-01-14T18:30:21Z urn:sha1:8bfd8cabd5778e622e3521d378200d54b9f9a5bf