mirrors/arti.git/crates/tor-netdoc/src/parse2/error.rs, branch arti-v1.8.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.8.02025-10-09T11:45:54Ztor-netdoc: parse2: Work around MSRV unhelpful lifetime2025-10-09T11:45:54ZIan Jacksonijackson@chiark.greenend.org.uk2025-10-07T17:18:40Zurn:sha1:f54a1d96a25bd16c9026d00d769af1f0bf8cac8d
1.85.1 rejects this, because it doesn't extend the lifetime of the
`format_args!`. 1.90 is fine with it.
I want to keep `format!` not `String::new()` so that it's easy to
change back. That means a clippy allow. Getting that to apply to the
code inside the derive is tricky, so I've enabled it for the whole
module. (IMO this clippy lint is pretty annoying anyway.)
tor-netdoc: parse2: Add column field to PaarsError and print it2025-10-09T11:45:54ZIan Jacksonijackson@chiark.greenend.org.uk2025-10-07T13:50:46Zurn:sha1:77b3e8b5e219a3656390cb63f87197c96040e676tor-netdoc: parse2: Add .column() accessor to ErrorProblem2025-10-09T11:45:54ZIan Jacksonijackson@chiark.greenend.org.uk2025-10-07T13:01:49Zurn:sha1:cbbe99e06e9ed8e1122dd1e29e167dd5fc6687f9
We'll want to general way to find the error problem column.
tor-netdoc: parse2: Add column field as far as ErrorProblem2025-10-09T11:45:54ZIan Jacksonijackson@chiark.greenend.org.uk2025-10-07T14:07:20Zurn:sha1:2a71d58d28809d20bfc9b595ffa305c1ad884f92
Provide facilities in ArgumnetStream for determining the column, and
add the field to all the error types up to and including ErrorProblem.
The value still needs to be propagated to ParseError, and printed there.
tor-netdoc: Introduce ArgumentError2025-10-09T11:45:43ZIan Jacksonijackson@chiark.greenend.org.uk2025-10-07T11:23:31Zurn:sha1:dfbda9d3033593d2670f354b65bd1a722fb2d580
This will allow us to (1) move field name handling out of the argument
parser method, and also (2) add columns more easily.
tor-netdoc: Have .reject_extra_args return a bespoke error2025-10-09T11:45:12ZIan Jacksonijackson@chiark.greenend.org.uk2025-10-07T11:30:59Zurn:sha1:afddda060daae551c70232df7b5495b9f0482c62
We're about to have some functions return ArgumentError and some
ErrorProblem. We don't want to provide a conversion directly between
these types, so instead introduce a new type that will be convertible
to either.
netdoc parse2: Don't duplicate the error source2025-09-29T12:58:22ZIan Jacksonijackson@chiark.greenend.org.uk2025-09-03T17:06:32Zurn:sha1:6725974a03082b52b8cd939c843dc2b4a2ce04ef
`problem` is the `#[source]`.
netdoc parse2: Fix invalid keyword error problem report2025-09-29T12:58:22ZIan Jacksonijackson@chiark.greenend.org.uk2025-09-03T14:50:42Zurn:sha1:ae712084aaa74ca5b2a138804d41874df1b2e206
`#[from]` is not `#[source]`. We need to print the inner error.
tor-netdoc: Introduce parse2, new parser2025-08-14T10:54:33ZIan Jacksonijackson@chiark.greenend.org.uk2025-08-06T13:13:39Zurn:sha1:59d30b6e775721b78cf81731ff81280fd187c16c
This isn't used anywhere yet. We're going to demonstrate it, and test
the demo, in a moment.