mirrors/arti.git/crates/tor-netdoc/src/parse2/derive.rs, branch mainmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=main2026-07-16T15:47:50ZUse new TimeRangeBound name throughout the tree2026-07-16T15:47:50ZIan Jacksonijackson@chiark.greenend.org.uk2026-07-16T14:35:45Zurn:sha1:92c26c4c07be73c91890ed3d7d4e53a06f26d0a1Use new TimeBound name throughout the tree2026-07-16T15:47:50ZIan Jacksonijackson@chiark.greenend.org.uk2026-07-16T14:32:14Zurn:sha1:5f57903ab4a8c280acf8a5bec274c50d5f544fd6tor-netdoc: parse2 derive: allow setting deprecated fields2026-06-16T19:28:08ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-16T18:57:37Zurn:sha1:24e3f4c37d89a35de1e73553e10add5f1bc169af
This makes it possible to derive from a struct with deprecated fields,
without triggering the warning.
This doesn't yet treat encoding as yet, because the only deprecated
field I encountered was `skip` which means the derived encoder never
mentions it.
tor-netcoc: NetdocParseableUnverified derive: forbid NetdocParseable2026-06-10T14:42:10ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-10T10:54:38Zurn:sha1:27b73a305059a26cb88ca3490c8a174015f4c5cdtor-netdoc: parse2: Add more docs about verification2026-06-10T14:42:10ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-10T10:56:28Zurn:sha1:31c16e2706411da246fcd60c1c692047cdf9c5eb
Prompted by
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/4070#note_3422636
tor-netdoc: parse2: use TimeRangebound in example2026-06-10T14:42:10ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-10T10:55:51Zurn:sha1:985c9acdee7c473cb10182ef23e72a2e9f680093tor-netdoc: fix a doc formatting typo2026-06-03T13:57:19ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-02T12:52:40Zurn:sha1:0207c69ca8375c3c564ee36c027e8c0502f16414tor-netdoc: Add crate:: to docs xrefs to avoid broken links2026-06-02T12:00:30ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-02T10:52:29Zurn:sha1:cfb9d75e051191b7c80308e690edfa2ec00cdbb7
Apparently, it is only correct to write
[`NetdocParseableUnverified`](derive_deftly_template_NetdocParseableUnverified),
*after* the definition of that template. Before then, the macro isn't
in scope.
Worse, rustdoc just treats it as a filename and doesn't spot the link,
so you don't get any kind of warning. I think this is an upstream bug,
https://github.com/rust-lang/rust/issues/157304
I found rustdoc's behaviour capricious. I don't intend to go through
the arti tree right now looking for similar patterns. Instead let's
hope the upstream bug gets fixed, and in the meantime do this crate::
thing when we notice we need it.
tor-netdoc: Rename NetdocUnverified trait to NetdocParseableUnverified2026-06-02T10:39:51ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-02T10:32:02Zurn:sha1:9b014fc0c02be35576fde6cb927e7c9645b5f827
The NetdocParseableUnverified derive macro implements this
trait (amongst other things). Traits and derive macros should have
aligned names.
This is only used for parsing, so let's keep the "Parseable" part of
the name.
I don't think the effort of deprecated alias, for downstream
compatibility, is worth it, our compatibility policy notwithstanding.
tor-netdoc: Fix two references to NetdocUnverified d-d template2026-06-02T10:37:43ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-02T10:30:30Zurn:sha1:0cd7be8e3e77a278177850feb660a87f8e1482e4
The trait is called NetdocUnverified, but the template is
NetdocParseableUnverified. This fixes a dead docs link (which somehow
isn't spotted by rustdoc, but is instead taken to refer to a
nonexistent file).