mirrors/arti.git/crates/tor-netdoc/src/parse2/derive.rs, branch arti-v2.2.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.2.0 2026-03-24T16:04:08Z Fix typos 2026-03-24T16:04:08Z Tobias Stoeckmann tobias@stoeckmann.org 2026-03-24T16:04:08Z urn:sha1:1fb2b8dd4aee7c943ce90d6631be473f2a296fe6 Typos found with codespell tor-netdoc: signature orderliness: add some xrefs 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-18T16:21:52Z urn:sha1:2a01b25ccd5e4ef3f9cfd2ed3b2c6e1bfe4d032c tor-netdoc: signature ordering: discuss an alternative impl approach 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-18T16:20:42Z urn:sha1:a5baaaff3ec1ed41a69f2f40ac8ce720ed833de2 Suggested-by: Clara Engler <cve@cve.cx> tor-netdoc: NetdocParseableSignatures: discuss ordering 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-17T16:30:56Z urn:sha1:e7d36a338f166b1fe614c580682234789e95dfe6 tor-netdoc: parse2: Add some navigational comments 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-11T12:26:01Z urn:sha1:6f7fab6084e9175f5e8c19844541135208151ddc I have been losing my way in this file a lot. This may help. tor-netdoc: parse2: Don't impl NetdocParseable for bodies of signed docs 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-11T12:24:55Z urn:sha1:5e5dc10f0f4d477bf0e8e4d2197610c149a59541 Such an impl is a footgun. Explain this in docs & comments. tor-netdoc: parse2: Unify top-level derive as NetdocUParseablenverified 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-09T17:48:49Z urn:sha1:575261d3f0c6f537640ecbe810396aac35652de2 Replace the two separate NetdocParseable and NetdocUnverified derives, for toplevel signed documents, with a single derive. This makes the derive API simpler. It will also make it reasonably possible to avoid deriving NetdocParseable directly for body structs. Such impls are a security hazard! In detail: * Rename NetdocUnverified to NetdocParseableUnverified * Have it use $IMPL_NETDOC_PARSEABLE from the NetdocParseable deftly module so that it derives NetdocParseable for the body. (We'll change this later in the series.) * Adjust the docs and all call sites. tor-netdoc: parse2: Break out IMPL_NETDOC_PARSEABLE in a deftly module 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-09T17:43:03Z urn:sha1:0512b8635c47acd34ae89305fb296a5addd4c10c We are going to want to reuse this parsing implementation in another top-level deftly template. tor-netdoc: parse2: Move hash out of signature items 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-11T13:06:35Z urn:sha1:aefa48e251f514a2cdbcb9e4a26292438b74af68 During encoding, including these hashes in the signature items makes no sense. The hashes are an *input* to the signature items, but not part of them. Move the hashes out of the items. Instead, provide each signatures section type with a hash accumulator type, in which the hash(es) are stored. tor-netdoc: parse2: Move hash out of signature items (prep) 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-10T16:51:43Z urn:sha1:fec9df146797de11dbe52e501cd648c5ee464dea Nonfunctional and formatting changes which reduce noise in the next commit.