mirrors/arti.git/crates/tor-netdoc/src/parse2.rs, branch arti-v2.4.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.4.02026-04-28T13:58:19Ztor-netdoc: Un-gate "plain-consensus" cargo feature2026-04-28T13:58:19ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-28T13:08:29Zurn:sha1:36d175b2728385c46067e421934f9262d0b8057e
As per #2492.
tor-netdoc: Gate authcert/encoded.rs and poc behind incomplete and plain-consensus2026-04-23T15:32:06ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-23T14:48:58Zurn:sha1:a37a1511e15cb7c2838d63f6417809a2ddc44f6e
"incomplete" is correct since encoded authcert depends on votes.
"plain-consensus" is going backwards, but stripping "plain-consensus"
gates from everything will be very intrusive.
tor-netdoc: Move raw_data_object to new container module2026-04-01T11:18:14ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-26T12:23:20Zurn:sha1:178293033011d1cb7f3ce471d652dd15e5d831c0
This will allow us to use it for encoding as well as parsing.
tor-netdoc: Apply deferred rustfmt churn to imports2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-11T12:59:17Zurn:sha1:9427eca66096a2a333fafb360532a3679dc52fd9tor-netdoc: parse2: Don't impl NetdocParseable for bodies of signed docs2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-11T12:24:55Zurn:sha1:5e5dc10f0f4d477bf0e8e4d2197610c149a59541
Such an impl is a footgun. Explain this in docs & comments.
tor-netdoc: parse2: Unify top-level derive as NetdocUParseablenverified2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-09T17:48:49Zurn:sha1:575261d3f0c6f537640ecbe810396aac35652de2
Replace the two separate NetdocParseable and NetdocUnverified derives,
for toplevel signed documents, with a single derive.
This makes the derive API simpler. It will also make it reasonably
possible to avoid deriving NetdocParseable directly for body structs.
Such impls are a security hazard!
In detail:
* Rename NetdocUnverified to NetdocParseableUnverified
* Have it use $IMPL_NETDOC_PARSEABLE from the NetdocParseable deftly
module so that it derives NetdocParseable for the body.
(We'll change this later in the series.)
* Adjust the docs and all call sites.
tor-netdoc: parse2: Move hash out of signature items2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-11T13:06:35Zurn:sha1:aefa48e251f514a2cdbcb9e4a26292438b74af68
During encoding, including these hashes in the signature items makes
no sense. The hashes are an *input* to the signature items, but not
part of them.
Move the hashes out of the items. Instead, provide each signatures
section type with a hash accumulator type, in which the hash(es) are
stored.
tor-netdoc: parse2: Introduce SignatureData struct2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-03T19:24:42Zurn:sha1:399c09200a008b02f4a9551fed22032feacf198d
This is going to contain body information, and the hashes, too.
tor-netdoc: NetdocParseableSignatures: Make into its own trait2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-03T19:08:33Zurn:sha1:785576835464aa7737e06d0088f377548df0e62btor-netdoc: NetdocParseableSignatures: Make into its own macro2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-03T19:04:43Zurn:sha1:e12328a78e03425465320d98ad695c00614dac8d
This is going to be its own trait and it is usually best if macros are
named after traits, rather than having the macro derive a different
trait depending on meta attributes.