mirrors/arti.git/crates/tor-netdoc/src/parse2.rs, branch arti-v2.2.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.2.02026-03-19T10:37:47Ztor-netdoc: Apply deferred rustfmt churn to imports2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-11T12:59:17Zurn:sha1:9427eca66096a2a333fafb360532a3679dc52fd9tor-netdoc: parse2: Don't impl NetdocParseable for bodies of signed docs2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-11T12:24:55Zurn:sha1:5e5dc10f0f4d477bf0e8e4d2197610c149a59541
Such an impl is a footgun. Explain this in docs & comments.
tor-netdoc: parse2: Unify top-level derive as NetdocUParseablenverified2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-09T17:48:49Zurn:sha1:575261d3f0c6f537640ecbe810396aac35652de2
Replace the two separate NetdocParseable and NetdocUnverified derives,
for toplevel signed documents, with a single derive.
This makes the derive API simpler. It will also make it reasonably
possible to avoid deriving NetdocParseable directly for body structs.
Such impls are a security hazard!
In detail:
* Rename NetdocUnverified to NetdocParseableUnverified
* Have it use $IMPL_NETDOC_PARSEABLE from the NetdocParseable deftly
module so that it derives NetdocParseable for the body.
(We'll change this later in the series.)
* Adjust the docs and all call sites.
tor-netdoc: parse2: Move hash out of signature items2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-11T13:06:35Zurn:sha1:aefa48e251f514a2cdbcb9e4a26292438b74af68
During encoding, including these hashes in the signature items makes
no sense. The hashes are an *input* to the signature items, but not
part of them.
Move the hashes out of the items. Instead, provide each signatures
section type with a hash accumulator type, in which the hash(es) are
stored.
tor-netdoc: parse2: Introduce SignatureData struct2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-03T19:24:42Zurn:sha1:399c09200a008b02f4a9551fed22032feacf198d
This is going to contain body information, and the hashes, too.
tor-netdoc: NetdocParseableSignatures: Make into its own trait2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-03T19:08:33Zurn:sha1:785576835464aa7737e06d0088f377548df0e62btor-netdoc: NetdocParseableSignatures: Make into its own macro2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-03T19:04:43Zurn:sha1:e12328a78e03425465320d98ad695c00614dac8d
This is going to be its own trait and it is usually best if macros are
named after traits, rather than having the macro derive a different
trait depending on meta attributes.
tor-netdoc: Apply rustfmt churn2026-03-03T18:57:38ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-03T18:57:38Zurn:sha1:96114eb9a68ca1c8062bc3f8761aee90115e003dtor-netdoc: Rename *Signed to *Unverified2026-03-03T18:56:01ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-03T18:46:00Zurn:sha1:9018c73d34ca60c5f671eeafc540446864998941
This was a weird name, and while working in this area it all seemed to
make the docs strange.
Rename it. This is quite invasive!
In theory we could have the macros generate compatibility aliases, but
that seems quite complex.
tor-netdoc: Move NetdocSigned to signatures.rs2026-03-03T18:53:21ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-03T18:45:21Zurn:sha1:a465848cbb09f602075bd6c7c3c7444d224a6f43
I keep not finding it because all the other signatures stuff is in
signatures.rs.