mirrors/arti.git/crates/tor-netdoc/src/lib.rs, branch arti-v2.5.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.02026-06-09T15:36:01Zmaint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
tor-netdoc: Rename FixedString to ConstantString2026-05-27T12:43:10ZIan Jacksonijackson@chiark.greenend.org.uk2026-05-18T16:44:11Zurn:sha1:c5ae62289528b33be9cb52c78147935c7d2a33c7
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3985#note_3413182
I left the word "fixed" in some of the docs and error messages, where
it seemed to make sense.
tor-netdoc: Provide FixedString and defined_fixed_string2026-05-27T12:42:59ZIan Jacksonijackson@chiark.greenend.org.uk2026-05-12T19:16:09Zurn:sha1:6f80d303ff1ce055b72917cac49c9a47c220d22b
We're going to want quite a lot of this for eg network-status-version.
tor-netdoc: Move FromStr and Display from NormalItemArgument to impls2026-04-29T10:20:28ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-27T14:43:55Zurn:sha1:4c75ba0cb8c036e4b330f1f10740e7c29e8379de
This allows implementing NormalItemArgument for types that can only be
parsed, or only displayed - or other combinations.
I noticed this restriction while inventing a type I later decided was
unnecessary. I still think it's a good change.
There is no practical impact elsewhere, since in practice downstream
code implements NormalItemArgument rather than relying on it.
tor-netdoc: Un-gate test2 module2026-04-28T13:58:19ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-28T13:47:12Zurn:sha1:f7d94cfb32c98307f4dc136ca410d83a1a97d1ce
Everything that this needs is un-gated now.
tor-netdoc: Un-gate top-level NetdocBuilder2026-04-28T13:58:19ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-28T11:54:50Zurn:sha1:8372f693f32ded32f82d0a9aaebe06d6ecf74bb1
This is only used for hsdescs right now. But it doesn't need to be
gated behind encode.
tor-netdoc: Un-gate parse2 and encode core2026-04-23T09:35:08ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-22T11:44:11Zurn:sha1:eba314abbfb3e4ec685bee4f3c31131b66f28792tor-netdoc: Provide AsMutSelf derive macro2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-05T16:44:11Zurn:sha1:d864e956248a32f38a903384f6ca84e7b07878fa
We're going to want this for sets of netdoc signature hashes.
Allow clippy::collapsible_if to trigger2026-02-16T15:22:24ZGabriela Moldovangabi@torproject.org2026-02-09T11:49:02Zurn:sha1:ade1d59e8e44c93b6ee447b72a2948a9652ec44e
`clippy::collapsible_if` started triggering after bumping the MSRV to
1.88.
Since this triggers from a lot of places, and since there even are a
couple of instances where we explicitly allow `clippy::collapsible_ifs`,
I've opened #2342 for deciding what to do about it.
maint/add_warning: Run script to add new warning2026-01-27T18:05:36ZGabriela Moldovangabi@torproject.org2026-01-27T18:05:36Zurn:sha1:a98faf72eb06b47700faeeac5a8a0dd0fc29b584
This adds the lint to all our crates.