mirrors/arti.git/crates/tor-netdoc/src/err.rs, branch derive-traits mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=derive-traits 2022-02-15T18:46:58Z Fix a rustdoc error. 2022-02-15T18:46:58Z Nick Mathewson nickm@torproject.org 2022-02-15T18:46:58Z urn:sha1:7c7bf2bd03c3f0675ab97b06affc6ee53c8222b7 Refactor tor-netdoc a bit more, to use Bug right. 2022-02-15T15:22:38Z Nick Mathewson nickm@torproject.org 2022-02-15T15:22:38Z urn:sha1:6bd21d43724dd31fba954bd5d88b38c96a78e756 Minimal compilation fix: InternalError=>Bug 2022-02-15T15:13:08Z Nick Mathewson nickm@torproject.org 2022-02-15T15:13:08Z urn:sha1:13f39ed8967bc49b0824317116cfddc3331bc690 This is a followup for !314 and !310 to fix compilation on main. Refactor tor_netdoc::Error 2022-02-14T18:08:28Z Nick Mathewson nickm@torproject.org 2022-02-14T18:08:28Z urn:sha1:b6d23c36bef1322e4fc6f89769222daa91c4d8f3 This error type doesn't impement HasKind, since the kind will depend on context. However, the existing implementation was pretty messy and inconsistent: Some errors had positions, some didn't. Some took messages as str, some as String. Some had internal errors that were somewhat orthogonal to their actual types. This commit refactors tor_netdoc::Error to use a ParseErrorKind, and adds a set of convenience functions to add positions and messages to the errors that need them. netdoc: Make doc-build errors a separate type 2022-02-14T15:46:04Z Nick Mathewson nickm@torproject.org 2022-02-14T15:46:04Z urn:sha1:b27c51d3a2ad4a7b8ec00c2a06be55af9459507a Every other case of tor_netdoc::Error means a parse failure. This one, though, means a failure to construct a document. netdoc: remove Error::Untimely. 2022-02-14T15:28:58Z Nick Mathewson nickm@torproject.org 2022-02-14T15:28:58Z urn:sha1:61867613a25e7499422cb02f2c0184fe02268056 Nothing creates this. address clippy's latest lint 2021-12-20T09:46:41Z Daniel Eades danieleades@hotmail.com 2021-12-20T09:46:41Z urn:sha1:9b51a52b53acf3efd468d17296b3671ed9a1af47 Resolve roughly half of the XXXXs. 2021-12-06T20:11:03Z Nick Mathewson nickm@torproject.org 2021-12-06T20:01:29Z urn:sha1:31b385c5b20205e879a847a9331c30a37dc2e6f5 We want to only use TODO in the codebase for non-blockers, and open tickets for anything that is a bigger blocker than a TODO. These XXXXs seem like definite non-blockers to me. Part of arti#231. Document every macro. 2021-09-07T12:44:47Z Nick Mathewson nickm@torproject.org 2021-09-07T12:44:47Z urn:sha1:bd2c9fd8c139303ff2965843c6e952e6ae152149 (The nightly version of clippy now includes macros for its missing_docs_in_private_items lint.) Move all crates into a `crates` subdirectory. 2021-08-27T13:53:09Z Nick Mathewson nickm@torproject.org 2021-08-27T13:53:09Z urn:sha1:557a0ff40b3731d4690767de27010bbeff08777d This will cause some pain for now, but now is really the best time to do this kind of thing.