mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.1 2022-11-15T21:58:23Z 2022-11-15T21:58:23Z Nick Mathewson nickm@torproject.org 2022-11-15T21:58:23Z urn:sha1:39615516fd30f5aa8da6ece97b6c5a0fdb9d8f9e We already have `Pos::Unknown` for an error at an unknown location and `Pos::None` for an error where no location is sensible. There's no reason to have an additional `Option` here. Additionally, the use of `Option` gave us a bug where our old `ParseError::at_pos()` method didn't actually set the position unless the position was already set. That's not what we want! Fixes #640. Finally, we have to fix a test that was a bit broken because it was working around #640. 2022-11-15T16:27:43Z Nick Mathewson nickm@torproject.org 2022-11-15T16:01:51Z urn:sha1:bc7780bffd218699a4869eb76f97595a4f0cbc8d Empty lines were previously reported as BadKeyword, which is confusing. 2022-06-23T19:42:45Z Nick Mathewson nickm@torproject.org 2022-06-23T19:42:45Z urn:sha1:38004a4f4dd3aa99b81b6585039e81dc77c17f32 Some of these were for decoding particular objects (we now say what kind of objects), and some were unrelated tor_cert errors that for some reason we had shoved into a tor_bytes::Error. There is now a separate tor_cert::CertError type, independent from tor_cert's use of `tor_bytes::Error` for parsing errors. 2022-06-07T16:45:57Z Nick Mathewson nickm@torproject.org 2022-05-26T17:40:19Z urn:sha1:102600e1c7d9cb39c5680df3e19bed07c3eea7c7 The kind type was already public, but we didn't give the user any way to get it. 2022-05-23T16:55:37Z Nick Mathewson nickm@torproject.org 2022-05-23T16:32:31Z urn:sha1:546ae3000eb179aedc97de30b0ccdb1d45b93395 It's a little overzealous sometimes, but it's mostly to the good. 2022-03-16T14:41:04Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-03-16T14:41:04Z urn:sha1:7564fabd687baf06f356ce22af8ae890ad8f17b7 The match was doing a deref coercion. Found by current nightly's needless_match (whose suggestion doesn't compile, https://github.com/rust-lang/rust-clippy/issues/8551 ) 2022-02-15T18:46:58Z Nick Mathewson nickm@torproject.org 2022-02-15T18:46:58Z urn:sha1:7c7bf2bd03c3f0675ab97b06affc6ee53c8222b7 2022-02-15T15:22:38Z Nick Mathewson nickm@torproject.org 2022-02-15T15:22:38Z urn:sha1:6bd21d43724dd31fba954bd5d88b38c96a78e756 2022-02-15T15:13:08Z Nick Mathewson nickm@torproject.org 2022-02-15T15:13:08Z urn:sha1:13f39ed8967bc49b0824317116cfddc3331bc690 This is a followup for !314 and !310 to fix compilation on main. 2022-02-14T18:08:28Z Nick Mathewson nickm@torproject.org 2022-02-14T18:08:28Z urn:sha1:b6d23c36bef1322e4fc6f89769222daa91c4d8f3 This error type doesn't impement HasKind, since the kind will depend on context. However, the existing implementation was pretty messy and inconsistent: Some errors had positions, some didn't. Some took messages as str, some as String. Some had internal errors that were somewhat orthogonal to their actual types. This commit refactors tor_netdoc::Error to use a ParseErrorKind, and adds a set of convenience functions to add positions and messages to the errors that need them.