mirrors/arti.git/crates/tor-netdoc/src/encode.rs, branch arti-v2.5.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.02026-06-24T12:34:06Ztor-netdoc: Replace trivial string slice2026-06-24T12:34:06ZClara Englercve@cve.cx2026-06-24T12:34:06Zurn:sha1:e017caa30580aa6480561f2770a6c3b088125cd1tor-netdoc: Use assert_eq_or_diff in three more places2026-06-11T11:38:51ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-11T11:31:31Zurn:sha1:d40b0d15e3315292948cf0ceeb8127ff2e14670feverywhere: Add #[allow(clippy::string_slice)]2026-06-09T16:02:36ZClara Englercve@cve.cx2026-06-09T16:00:38Zurn:sha1:d0af4abbd7b371f1eade609202a730cd9a1c21d3
This commit adds #[allow(clippy::string_slice)] to all functions in the
code where string slices are used, alongside a TODO comment.
We do this add the function header to have it consistent, as things like
expression based allow's are still experimental.
maint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
Upgrade rand crates to 0.10.2026-05-12T20:55:43ZWesley Aptekar-Casselsme@wesleyac.com2026-05-07T20:06:21Zurn:sha1:a18167928901d8c88cd1cdd87346de8ad1ee42a2
When the circ-padding feature is enabled, we use maybenot, which does
not yet support rand 0.10. In the meantime, enabling this feature pulls
in rand 0.9. This is not ideal, but should be okay as a temporary
situation.
This also replaces the use of ReseedingRng (which was removed in 0.10)
with the reseeding_rng crate. This is somewhat less performant, but it
should be okay.
tor-netdoc: Move FromStr and Display from NormalItemArgument to impls2026-04-29T10:20:28ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-27T14:43:55Zurn:sha1:4c75ba0cb8c036e4b330f1f10740e7c29e8379de
This allows implementing NormalItemArgument for types that can only be
parsed, or only displayed - or other combinations.
I noticed this restriction while inventing a type I later decided was
unnecessary. I still think it's a good change.
There is no practical impact elsewhere, since in practice downstream
code implements NormalItemArgument rather than relying on it.
tor-netdoc: Implement encoding traits for Arc<T>2026-04-21T12:42:43ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-07T11:46:00Zurn:sha1:ffc631750f542aa7b41d5fd1d9a035004690bd15tor-netdoc: encode: Move various ItemArgument impls to impls.rs2026-04-01T11:33:48ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-01T10:31:43Zurn:sha1:cadbd63b8628b668efd0e6d471d0122195d462f9tor-netdoc: impl encoding traits for rsa::PublicKey2026-04-01T11:18:14ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-26T11:37:39Zurn:sha1:8555bed910ea6cb424e1ed3519da911c30f8ab73tor-netdoc: Provide ItemEncoder::text_sofar()2026-04-01T11:18:14ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-26T13:49:05Zurn:sha1:ecca83cefb0d30dcd7211009de20a0465c45a367