mirrors/arti.git/crates/tor-netdoc/src/encode.rs, branch arti-v2.0.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.0.02025-12-10T11:05:28Ztor-netdoc: Add two TODOs re trait naming2025-12-10T11:05:28ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-09T17:01:38Zurn:sha1:c21970fb5cb8d165370e6a33a48d7fd4e64c4d01tor-netdoc: derive netdoc encoding traits2025-12-10T11:05:28ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-08T12:30:03Zurn:sha1:d101894ca656906c4d6ddb3cb82f31aae4970a72
Signature encoding is not yet supported. We need to consider how this
will work.
tor-netdoc: encoding: Provide multiplicity module2025-12-10T11:05:28ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-08T12:30:29Zurn:sha1:3fc25a9325703282605730b0ffa5cefe4d4f4a5a
This is quite like the one for parse2, but separate for Reasons.
Also add a bit of explanation to parse2's multiplicity.rs, about why
there are all these different FooSetMethods traits, which the encoder
doesn't need.
tor-netdoc: encoding: Add new traits that we will derive2025-12-10T11:05:28ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-12T12:28:34Zurn:sha1:a6338b891763de4c9fdacc1bbcb6759b259b92cf
And implement them for Void and tuples, as applicable.
tor-netdoc: Add imports to encode module, for new encode derive2025-12-10T11:05:28ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-01T14:32:12Zurn:sha1:8a8a393fbd3e6b745ad1aa306db0294b63936be3
Adding these all at the beginning helped me with churn in this branch.
The allow(unused) will go away again shortly.
tor-netdoc: Provide ItemEncoder::finish2025-12-04T12:54:46ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-01T14:24:09Zurn:sha1:29e0dfa34749bf73315bfe9f41acfda1c4f7ecd7
This provides a way to explicitly consume the encoder and finish the
item, without use of mem::drop.
tor-netdoc: Improve and expose args_raw_string2025-12-04T12:54:46ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-01T12:53:20Zurn:sha1:d17443f3f6815629c37ae6dc66e44209775e702b
The new derive is going to want this. So it would need to be at least
`#[doc(hidden)]`. But it makes sense to expose it.
But, it had a weird signature. Make its signature like that of `.arg_empty()`.
(Note that an ItemEncoder contains just a `&mut NetdocEncoder`.)
tor-netdoc: Better error from empty argument (fmt)2025-12-04T12:54:14ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-01T14:43:30Zurn:sha1:471ef01b461f3f0af3441db33b2f55b574a700dftor-netdoc: Better error from empty argument2025-12-04T12:54:14ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-01T11:10:06Zurn:sha1:7df2e061d1fd1e09ff7d75cc4cfe63c139f49c05
talking about the "keyword argument syntax" makes it sound a bit like
its' the *keyword* that is wrong.
tor-netdoc: Throw rather than squirreling error from NormalItemArgument2025-12-04T12:54:14ZIan Jacksonijackson@chiark.greenend.org.uk2025-12-01T11:09:57Zurn:sha1:a3044987c98fc9254ec12124efaa7546100f920d
NormalItemArgument is for types where we use the Display as the netdoc
argument formatter. But what if gives the empty string?
Previously we would allow `add_arg` to handle the error. That would
record it in the NetdocEncoder. That's kind of OK, but it will
prevent the caller from aborting early (and from elaborating the error).