mirrors/arti.git/crates/tor-netdoc/src/doc, branch derive-traits mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=derive-traits 2022-02-14T18:08:28Z Refactor tor_netdoc::Error 2022-02-14T18:08:28Z Nick Mathewson nickm@torproject.org 2022-02-14T18:08:28Z urn:sha1:b6d23c36bef1322e4fc6f89769222daa91c4d8f3 This error type doesn't impement HasKind, since the kind will depend on context. However, the existing implementation was pretty messy and inconsistent: Some errors had positions, some didn't. Some took messages as str, some as String. Some had internal errors that were somewhat orthogonal to their actual types. This commit refactors tor_netdoc::Error to use a ParseErrorKind, and adds a set of convenience functions to add positions and messages to the errors that need them. netdoc: Make doc-build errors a separate type 2022-02-14T15:46:04Z Nick Mathewson nickm@torproject.org 2022-02-14T15:46:04Z urn:sha1:b27c51d3a2ad4a7b8ec00c2a06be55af9459507a Every other case of tor_netdoc::Error means a parse failure. This one, though, means a failure to construct a document. Merge branch 'refactor/must-use-self' into 'main' 2021-12-20T18:38:18Z eta tor@eta.st 2021-12-20T18:38:18Z urn:sha1:0cdf65c2565a02eb5606d26396ea8165a5506749 address clippy's latest lint See merge request tpo/core/arti!205 tor-netdoc: Change an XXX to a TODO. 2021-12-20T14:46:56Z Nick Mathewson nickm@torproject.org 2021-12-20T14:46:56Z urn:sha1:8cf143217e2655b90cb2a8690bc4ef75957906df Our behavior in handling not-yet-valid router descriptors doesn't match the C Tor implementation, but it's not a big deal: we don't currently use router descriptors at all. tor-netdoc: Use a more correct error type 2021-12-20T13:58:30Z Nick Mathewson nickm@torproject.org 2021-12-20T13:58:30Z urn:sha1:6299ca70b43a8e93064fbd12e249f74566761d68 If we fail to convert a curve25519 key to an ed25519 key for checking the onion-key crosscert, don't call that an internal error: it means that something is wrong with the provided ntor key. Remove an XXXX about ed25519 signatures. 2021-12-20T13:53:42Z Nick Mathewson nickm@torproject.org 2021-12-20T13:53:42Z urn:sha1:92e53bff62742bce06989f6ad560f9510274d520 As of tor-spec commit 01122c5bd7d2f0f, the spec is no longer ambiguous on this point. address clippy's latest lint 2021-12-20T09:46:41Z Daniel Eades danieleades@hotmail.com 2021-12-20T09:46:41Z urn:sha1:9b51a52b53acf3efd468d17296b3671ed9a1af47 s/hidden/onion/g in code comments 2021-12-13T21:18:53Z Neel Chauhan neel@neelc.org 2021-12-13T21:18:53Z urn:sha1:d621166c80331fd6d8ccd7ad7e27420c4da4c0d8 fix nightly clippy errors 2021-12-09T11:16:23Z Trinity Pointard trinity.pointard@gmail.com 2021-12-09T11:16:23Z urn:sha1:9753a7ee06d1dad9b9dbaa1653593bb545d4cf59 Resolve roughly half of the XXXXs. 2021-12-06T20:11:03Z Nick Mathewson nickm@torproject.org 2021-12-06T20:01:29Z urn:sha1:31b385c5b20205e879a847a9331c30a37dc2e6f5 We want to only use TODO in the codebase for non-blockers, and open tickets for anything that is a bigger blocker than a TODO. These XXXXs seem like definite non-blockers to me. Part of arti#231.