mirrors/arti.git/crates/tor-netdoc/src/doc, branch arti-v2.2.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.2.02026-03-26T19:20:16Ztor-netdoc: Port to web-time-compat2026-03-26T19:20:16ZNick Mathewsonnickm@torproject.org2026-03-26T14:39:48Zurn:sha1:cec5d8e8194a03ace7e45ebbeba95a7da0c3f7cbFix typos2026-03-24T16:04:08ZTobias Stoeckmanntobias@stoeckmann.org2026-03-24T16:04:08Zurn:sha1:1fb2b8dd4aee7c943ce90d6631be473f2a296fe6
Typos found with codespell
tor-netdoc: Apply deferred rustfmt churn to imports2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-11T12:59:17Zurn:sha1:9427eca66096a2a333fafb360532a3679dc52fd9tor-netdoc: parse2: Don't impl NetdocParseable for bodies of signed docs2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-11T12:24:55Zurn:sha1:5e5dc10f0f4d477bf0e8e4d2197610c149a59541
Such an impl is a footgun. Explain this in docs & comments.
tor-netdoc: parse2: Don't impl NetdocParseable for bodies of signed docs (pre-fmt)2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-11T12:24:50Zurn:sha1:e98087c302527047d3505d03b424b2e8ef8cf605tor-netdoc: authcert test: Avoid using NetdocParseable for AuthCert2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-10T15:34:25Zurn:sha1:356afa6e7993ceb726d4c0784b7a17d39e6aef75
We want to stop deriving NetdocParseable directly for body structs.
This test case does in fact parse a signed authcert and extract just
the body without verifying the signatures. That's fine in a test, but
we're going to make it involve some hoop-jumping. So, jump those
hoops.
tor-netdoc: parse2: Unify top-level derive as NetdocUParseablenverified2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-09T17:48:49Zurn:sha1:575261d3f0c6f537640ecbe810396aac35652de2
Replace the two separate NetdocParseable and NetdocUnverified derives,
for toplevel signed documents, with a single derive.
This makes the derive API simpler. It will also make it reasonably
possible to avoid deriving NetdocParseable directly for body structs.
Such impls are a security hazard!
In detail:
* Rename NetdocUnverified to NetdocParseableUnverified
* Have it use $IMPL_NETDOC_PARSEABLE from the NetdocParseable deftly
module so that it derives NetdocParseable for the body.
(We'll change this later in the series.)
* Adjust the docs and all call sites.
tor-netdoc: parse2: Move hash out of signature items2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-11T13:06:35Zurn:sha1:aefa48e251f514a2cdbcb9e4a26292438b74af68
During encoding, including these hashes in the signature items makes
no sense. The hashes are an *input* to the signature items, but not
part of them.
Move the hashes out of the items. Instead, provide each signatures
section type with a hash accumulator type, in which the hash(es) are
stored.
tor-netdoc: parse2: Introduce SignatureData struct2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-03T19:24:42Zurn:sha1:399c09200a008b02f4a9551fed22032feacf198d
This is going to contain body information, and the hashes, too.
tor-netdoc: NetdocParseableSignatures: Make into its own macro2026-03-19T10:37:47ZIan Jacksonijackson@chiark.greenend.org.uk2026-03-03T19:04:43Zurn:sha1:e12328a78e03425465320d98ad695c00614dac8d
This is going to be its own trait and it is usually best if macros are
named after traits, rather than having the macro derive a different
trait depending on meta attributes.