mirrors/arti.git/crates/tor-netdoc/src/doc/routerdesc.rs, branch arti-v2.5.1 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.1 2026-07-30T14:23:54Z tor-netdoc: Mark RouterDescUnverified::verify() incomplete 2026-07-30T14:23:54Z Clara Engler cve@cve.cx 2026-07-30T13:26:57Z urn:sha1:cac9afaa23b9b4fc892eca064a535d4f0d14651d Better do it before the release so we can think about it a bit more. tor-netdoc: Properly obtain min/max for start and end time 2026-07-30T12:56:16Z Clara Engler cve@cve.cx 2026-07-30T12:54:47Z urn:sha1:c9a756818fea9c3bc4f6098e4351923d6bb500d2 We need to obtain the maximum of the lower bound and the minimum of the upper bound instead of vice versa. Another example on why we should replace this with a better implementation. Likewise, `expiry` in the legacy verification code is also obtained like that. tor-netdoc: Rename min/max to start and end time 2026-07-30T12:51:54Z Clara Engler cve@cve.cx 2026-07-30T12:51:54Z urn:sha1:495bfbaec82016d663e53ed2a67a6c738eb0606d This makes it more clear, besides it will sound more "correct" with the next commit applied. tor-netdoc: Add various TODO follow-ups 2026-07-30T10:24:37Z Clara Engler cve@cve.cx 2026-07-29T13:51:46Z urn:sha1:0e7a088db3ae38756590fa0d1dce8ad1dcf7e756 tor-netdoc: Make RouterDescUnverified::verify() public 2026-07-30T10:24:37Z Clara Engler cve@cve.cx 2026-07-29T13:50:38Z urn:sha1:4d1d28dc3851e2ad4be94376750b469a5804f45c tor-netdoc: Run cargo-fmt 2026-07-30T10:24:37Z Clara Engler cve@cve.cx 2026-07-29T13:04:28Z urn:sha1:93b000dd439759250939c262525df8406b655a47 tor-netdoc: Allow dead_code for RouterDesc::verify 2026-07-30T10:24:37Z Clara Engler cve@cve.cx 2026-06-29T13:13:17Z urn:sha1:d9ba355e6667ee53173290417f7dd504099bc899 Otherwise clippy complains. tor-netdoc: Add large RouterDesc verification test 2026-07-30T10:24:37Z Clara Engler cve@cve.cx 2026-06-29T12:55:31Z urn:sha1:ab80dbc635f4e2fef5277b5fbc255bb807f8c2b8 This commit adds a comprehensive test for router descriptor verification that tests various valid and invalid edge cases. tor-netdoc: Add test only rd_encode_sign() method 2026-07-30T10:24:37Z Clara Engler cve@cve.cx 2026-06-25T11:15:07Z urn:sha1:1c07facfe939a7b2aa7bdc4ceed0359ef3118356 This is a bad encode_sign() method for RouterDesc that is testing only and will be used soon to implement testing for invalid router descriptors, for which we may need to create invalid ones in the first place. tor-netdoc: Call .verify() in test_parse2_simple 2026-07-30T10:24:37Z Clara Engler cve@cve.cx 2026-06-25T10:35:48Z urn:sha1:dca896f723bc344505069bc9055f9bdf42bdbfb6