mirrors/arti.git/crates/tor-netdoc/src/doc/netstatus, branch arti-v1.8.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.8.02025-11-24T18:34:40Ztor-netdoc: Rename RelayFlagsParser to relay_flags::Parser2025-11-24T18:34:40ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-24T18:32:05Zurn:sha1:2df8bf8d3230671a0e049cb88af8903278c65381
Since we expose the relay_flags module, it makes sense to give this a
shorter name.
(It had a longer name when it was part of the netstatus module.)
tor-netdoc: relay_flags: Remove two now-not-needed type aliases2025-11-24T18:34:40ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-24T18:30:29Zurn:sha1:f27774d393ca14148e8ee6f93a220a392cddb1be
The generic parser type is easy enough to name now.
RelayFlags: Use RelayFlag enum variant names everywhere2025-11-18T19:50:23ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-18T18:55:10Zurn:sha1:c37e44403416b7f1abbd62d080b698da35d04537
Abolish the constants with the transitional names.
This also abolishes the controversial name `H_S_DIR`, which Rust case
transformation rules generated from `HSDir`.
RelayFlags: Use the singular RelayFlag for naming individual flags2025-11-18T19:44:21ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-18T18:36:08Zurn:sha1:3245738729e1d93be48485f2877a9e17ba2e7f28
We're going to separate RelayFlag from RelayFlags.
We could continue to provide a bunch of constant values for
RelayFlags, for each individual type, but that would involve an ad-hoc
derive, and would still be a bit of an unusual API.
Instead, we're going to make ``RelayFlag` a normal enum.
In this commit, we change everyone to refer to it by its singular
name. Hopefully separating out this bulk change makes both this, and
the core commit, easier to review.
tor-netdoc: rs builder: Take Into<RelayFlags>2025-11-18T19:44:21ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-18T18:27:55Zurn:sha1:0a56f469d2568ba4e5339bde5d6b0b68a26581ba
Many call sites pass one flag. We're going to have a type-level
distinction between a single flag and a set. But that's annoying at
many of the call sites which want to specify a fixed single flag.
Note that `set_flags` doesn't only set flags. It replaces them.
tor-netdoc: RelayFlags: Tidy up from_item for flags2025-11-18T19:44:21ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-18T17:32:37Zurn:sha1:c4bcd24cad21bbdab4b2e7466497e2bd7a5aae5d
Implement this on DocRelayFlags instead, since that's what it returns.
And change the name to from_item_consensus to highlight its semantic
restriction. (It's not generic over the implied flags, so it can only
do one thing.)
tor-netdoc: Be able to retain unknown flags2025-11-18T17:06:51ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-10T17:06:10Zurn:sha1:e05c7622a8f159f91386989f57d67412538dd407tor-netdoc: Introduce DocRelayFlags for relay flags in a network document2025-11-18T17:06:51ZIan Jacksonijackson@chiark.greenend.org.uk2025-10-23T14:12:44Zurn:sha1:3dfea170e26a9d9f140830b418eca3191b337fb0
This will have space for unknown flags.
tor-netdoc: Separate ConsensusRelayFlagsParser and VoteRelayFlagsParser2025-11-18T17:06:51ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-10T16:50:39Zurn:sha1:a16441bb27dce19d42e1e04ad4fbff0f74b26d86
Provide a per-variety alias and use it for parsing; no longer impl
ItemValueParseable for RelayFlags.
tor-netdoc: Rename RelayFlags elements for regularity vs spec2025-11-18T17:06:51ZIan Jacksonijackson@chiark.greenend.org.uk2025-10-23T13:35:07Zurn:sha1:f7317d7068884860c1d1a69e30eca962ee7da827
Add underscores so that the spec keywords and the flag constants
correspond (according to `paste`'s case-changing rules).