mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=derive-traits 2022-02-14T18:08:28Z 2022-02-14T18:08:28Z Nick Mathewson nickm@torproject.org 2022-02-14T18:08:28Z urn:sha1:b6d23c36bef1322e4fc6f89769222daa91c4d8f3 This error type doesn't impement HasKind, since the kind will depend on context. However, the existing implementation was pretty messy and inconsistent: Some errors had positions, some didn't. Some took messages as str, some as String. Some had internal errors that were somewhat orthogonal to their actual types. This commit refactors tor_netdoc::Error to use a ParseErrorKind, and adds a set of convenience functions to add positions and messages to the errors that need them. 2021-12-02T05:51:49Z Neel Chauhan neel@neelc.org 2021-12-02T05:51:49Z urn:sha1:f5362028b4a988cfd73abe4174bdedd14dbd29ca 2021-11-16T18:31:00Z eta tor@eta.st 2021-11-16T18:31:00Z urn:sha1:a85e83c8072a41407a33881157204ffe6bc2f840 Put most non-universally-needed functionality behind features Closes #125 See merge request tpo/core/arti!129 2021-11-12T18:54:03Z Nick Mathewson nickm@torproject.org 2021-11-12T18:54:03Z urn:sha1:69bb6313fd16a232d06af9596c6b3bb72115a0f1 This field isn't used in modern Tor, and has never been used in Arti. If tor!489 is merged, then it will no longer contain a useful value in future consensuses. We shouldn't store it, or else somebody else will get the smart idea of using it for something. This commit breaks API compatibility for tor-netdoc with the `build_docs` feature enabled. I haven't entered that into the semver_status.md file, since we already have a pending tor-netdoc API breaker in !129. 2021-11-12T17:15:34Z Nick Mathewson nickm@torproject.org 2021-11-12T16:49:29Z urn:sha1:773c0dc3326d942a3d15105f572627b00b3b8e38 Clients never need these. Part of #125. 2021-11-12T17:15:34Z Nick Mathewson nickm@torproject.org 2021-11-12T16:38:45Z urn:sha1:84fbff54a5b071de65ac3cc55f61a49f07266441 2021-10-19T20:21:12Z Nick Mathewson nickm@torproject.org 2021-10-19T20:21:12Z urn:sha1:445ec6d22053d3f76534844b6c02aefa1fbaedd7 (One represents code that I forgot to write.) 2021-09-07T12:44:47Z Nick Mathewson nickm@torproject.org 2021-09-07T12:44:47Z urn:sha1:bd2c9fd8c139303ff2965843c6e952e6ae152149 (The nightly version of clippy now includes macros for its missing_docs_in_private_items lint.) 2021-08-27T13:53:09Z Nick Mathewson nickm@torproject.org 2021-08-27T13:53:09Z urn:sha1:557a0ff40b3731d4690767de27010bbeff08777d This will cause some pain for now, but now is really the best time to do this kind of thing.