mirrors/arti.git/crates/tor-netdoc/src/doc/netstatus/dir_source.rs, branch mainmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=main2026-06-24T12:24:30Ztor-netdoc: Replace string slices with str::get() in doc (fmt)2026-06-24T12:24:30ZClara Englercve@cve.cx2026-06-24T12:24:30Zurn:sha1:648117f59cd083736d7055e2399d87034bd47f11
No functional change, just reformatting.
tor-netdoc: Replace string slices with str::get() in doc2026-06-24T12:22:30ZClara Englercve@cve.cx2026-06-24T12:22:30Zurn:sha1:9587e70a6f8155f15dc454a1d70d14d1fd774382
This commit replaces the use of string slices with str::get() in all
document related code.
While this is not a perfect replacement for it, the relevant parts in
the code heavily depend upon the byte offsets returned by the low level
(legacy) parser where changing it would lead to a very big refactoring.
Nonetheless, this approach is better because returning a bug is better
than crashing.
everywhere: Add #[allow(clippy::string_slice)]2026-06-09T16:02:36ZClara Englercve@cve.cx2026-06-09T16:00:38Zurn:sha1:d0af4abbd7b371f1eade609202a730cd9a1c21d3
This commit adds #[allow(clippy::string_slice)] to all functions in the
code where string slices are used, alongside a TODO comment.
We do this add the function header to have it consistent, as things like
expression based allow's are still experimental.
tor-netdoc: Un-gate features impls in doc/netstatus/dir_source.rs (rewrap)2026-04-28T13:58:19ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-28T11:59:17Zurn:sha1:df08d15fdc8cfaf4e7ca0c0d0358ffef82583556tor-netdoc: Un-gate features impls in doc/netstatus/dir_source.rs2026-04-28T13:58:19ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-28T11:51:46Zurn:sha1:a2bf074c4756660f202abeb2d55aa62be76b2e31
There are no outstanding TODOs here.
tor-netdoc: consensus authority section: ConsensusAuthoritySection2026-04-27T15:49:05ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-15T14:26:21Zurn:sha1:221c0bf0c7f041fc84c60c8a844fac34da7d5fe5
Replace poc code with new ConsensusAuthoritySection.
This is an entirely new parsing approach.
Key differences:
* We parse the arguments to dir-source, which poc didn't.
* We don't clone the input and fully parse the first item; instead,
we dismantle the dir-source line ad-hoc to determine the item type.
* Rather than a Vec of Enums, we parse into two Vecs
of the different entry types.
The few lines that aren't rewritten show up as moved in
git show --color-moved --color-moved-ws=allow-indentation-change
but I suggest reviewing the new implementation de novo.
tor-netdoc: consensus authority section: SupersededAuthorityKey2026-04-27T15:49:05ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-15T14:25:28Zurn:sha1:fe9565b7f290e52092bb232e87f3c6b488302f50
This is the type corresponding to a "superseded authority key entry",
which is a single dir-source line with a weird nickname.
tor-netdoc: DirSource: move to new dir_source module2026-04-27T15:49:05ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-21T11:53:23Zurn:sha1:b85b49debd464ad1bea849bbaeb026b1e8b7b453
This is going to handle the bizarre `-legacy` nickname encoding for
superseded authority keys. That's going to be a fair amount of code,
some derived from DirSource. Make a module for it all.
We're going to take a different approach that in poc. So there's
going to be all-new code and then the poc version will be deleted.
They don't resemble each other very much.
In this commit: just code motion, and the creation of the new module
with associated doc comment. Review with --color-moved.