mirrors/arti.git/crates/tor-netdoc/src/doc/microdesc.rs, branch arti-v1.1.4 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.4 2023-02-15T17:17:01Z tor-netdoc: Remove many needless calls to .iter() and .into_iter() 2023-02-15T17:17:01Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-02-15T16:18:53Z urn:sha1:4a91c732fe4b597ad4e90564ca4630ac3048938a netdoc: Require that unrecognized tokens be handled explicitly. 2023-02-03T16:33:30Z Nick Mathewson nickm@torproject.org 2023-02-03T16:33:30Z urn:sha1:73199ebf68815f7bc1ef6f85f5ce04d3e2620a2e Now we require that, for all `SectionRules`, either the caller say how to handle unrecognized tokens (using `.add(UNRECOGNIZED...)`), or that they explicitly reject unrecognized tokens (using `reject_unrecognized`()`.) This solution uses an assert!() rather than an Error to indicate failure. I say that's fine, since 1. This is a crate-internal API. 2. We never dynamically construct SectionRules according to different behavior: they are always prefabricated in a fixed code block. Thus, if we test a parser at all, we will make sure that its SectionRules are well-formed. I considered and explicitly rejected a solution where the builder had to be finalized with separate methods `build_strict()` or `build_tolerant()`: It's too easy IMO for the caller to forget what these call means. Prevents further recurrences of #752. Closes #752. netdoc: Switch SectionRules building to use a Buidler pattern. 2023-02-03T16:14:00Z Nick Mathewson nickm@torproject.org 2023-02-03T16:14:00Z urn:sha1:13d5452e2e6052e358da95c0becd7b522cf1183f No new behavior yet. Allow clippy::unchecked_duration_subtraction in tests 2023-01-27T13:28:02Z Nick Mathewson nickm@torproject.org 2023-01-27T13:01:45Z urn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada This panics on error, and we're fine with a panic on misbehavior in tests. Merge branch 'test-lints' into 'main' 2023-01-06T17:16:09Z eta tor@eta.st 2023-01-06T17:16:09Z urn:sha1:118050e54cdb7d6e55f8eb375b82cbfc8466a809 Add test lint blocks to all "mod test" See merge request tpo/core/arti!937 Use parse_rfc3339() in the tor-netdoc crate 2022-12-16T20:56:00Z Neel Chauhan neel@neelc.org 2022-12-16T20:35:58Z urn:sha1:a180f911bd47c726fb53017372b34da3fc705b30 test lint blocks: Add many many automatically 2022-12-12T18:00:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-12-12T17:58:40Z urn:sha1:125a455bdcca841931f33f83f206e57637ae85c4 This is precisely the result of running the rune in maint/adhoc-add-lint-blocks. add feature annotation to fields made visible through visible::StructFields 2022-08-24T16:22:41Z trinity-1686a trinity@deuxfleurs.fr 2022-08-18T00:24:22Z urn:sha1:ca99e9f63587fcf8164b813f4ca265507002ea53 microdesc: make sure we recover from an error in the final md. 2022-06-07T16:45:59Z Nick Mathewson nickm@torproject.org 2022-05-26T18:20:36Z urn:sha1:d30899d38791d1f81a8d58ac14dbc79fdc062fa7 (This is slightly different from recovering from errors in the middle of a list of mds, since in this case we _can't_ advance to the next md.) Also, note that a given branch is probably not reachable. netdoc: test case for microdesc with no ed25519 id. 2022-06-07T16:45:57Z Nick Mathewson nickm@torproject.org 2022-05-26T18:11:35Z urn:sha1:42d6d02fbee7a16ac7211292acc378f3c03662ee The "bad-id" microdescriptor is hand-edited based on one from a Chutney network.