mirrors/arti.git/crates/tor-netdoc/src/doc/hsdesc/middle.rs, branch arti-v1.1.6

netdoc: replace a test TODO with a reference to other tests

2023-06-26T12:45:06Z

The tests called for here already existed.

netdoc: fill in some test data

2023-06-23T15:23:18Z

This resolves some TODO HS items now that we are confident we want to have these actual examples in our tests.

netdoc: Introduce HsDescError

2023-06-22T16:43:30Z

For higher-level HsDesc-related functions, this type indicates where exactly an error occurred. It lets us distinguish decryption errors from parsing errors, and attribute responsibility to the hsdir, the onion service, or the user's lack of encryption. This lets us remove some just-introduced complexity in tor-hsclient.

netdoc::doc::hsdesc changes to let us downgrade/remove allows

2023-06-16T16:24:05Z

netdoc: use ct_lookup for rend descriptor cookie lookup

2023-06-16T16:24:05Z

(I doubt that there is a viable side channel here, but still we might as well get in the habit of doing these things properly.)

netdoc: Downgrade an HS todo wrt HS_DESC_AUTH_TYPE

2023-06-16T16:24:05Z

netdoc: Rename `ParseError{Kind, Source}` to `NetdocError{Kind, Source}`.

2023-05-10T14:52:28Z

`ParseErrorSource` was originally meant to represent a parsing error, this enum has since gained some variants that aren't really parsing related (`Signature`, `CertSignature`, `UntimelyDescriptor`). Since this error type is now used for general-purpose netdoc errors, let's rename `ParseError{Kind, Source}` to `NetdocError{Kind, Source}`. Signed-off-by: Gabriela Moldovan

tor-netdoc: Expose test data under new "testing" feature flag

2023-04-05T10:02:36Z

Stop requiring the caller to supply `AuthClient`s.

2023-03-31T14:04:15Z

`AuthClient`s were originally meant to represent parsed `auth-client` lines. In !1070, this struct was repurposed for representing individual authorized clients in the HS descriptor encoder. However, hidden services will likely use a list of public keys to represent the authorized clients rather than a list of `AuthClient`s, as the information from an `AuthClient` (`client_id`, `iv`, `encrypted_cookie`) likely won't be immediately available to the hidden service. This change updates the HS descriptor encoder to represent authorized clients as a list of `curve25519::PublicKey`s. As such, it is now the responsibility of the encoder to create the `client_id`, `iv`, and `encrypted_cookie` using the available keys, the unencrypted descriptor cookie, and HS subcredential. Signed-off-by: Gabriela Moldovan

Add builder for encoding hidden service descriptors.

2023-03-24T18:57:49Z

This introduces the `NetdocBuilder` trait described in `netdoc-builder.md` and a new `tor-netdoc::doc::hsdesc::build` module, which exports the `HsDescBuilder`. Hidden services will use `HsDescBuilder` to build and encode hidden service descriptors. There are several TODOs in the code that I'm planning to address separately. Partially addresses #745. Signed-off-by: Gabriela Moldovan