mirrors/arti.git/crates/tor-netdoc/src/doc/hsdesc/inner.rs, branch arti-v1.1.3

Add builder for encoding hidden service descriptors.

2023-03-24T18:57:49Z

This introduces the `NetdocBuilder` trait described in `netdoc-builder.md` and a new `tor-netdoc::doc::hsdesc::build` module, which exports the `HsDescBuilder`. Hidden services will use `HsDescBuilder` to build and encode hidden service descriptors. There are several TODOs in the code that I'm planning to address separately. Partially addresses #745. Signed-off-by: Gabriela Moldovan

tor-netdoc: Validate inner certs in HsDesc

2023-03-01T14:48:51Z

This makes our implementation behave the same as the C tor implementation, by validating all of the expiration and signatures on the certificates in the inner document. (It is still not semantically necessary to check these certs: the document in which they appear is already signed by the key with which they are allegedly signed.) Closes #744

netdoc: Remove a TODO hs comment.

2023-02-17T20:06:09Z

It said to check whether C enforces an absence of extraneous bytes at the end of the link specifiers. It does, in `hs_desc.c:decode_link_specifiers()`, where it says: ``` if (link_specifier_list_parse(&specs, decoded, (size_t) decoded_len) < decoded_len) { goto err; } ``` The comparison with "decoded_len" checks whether all the bytes were decoded.

tor-netdoc: Run rustfmt (separately from the refactoring)

2023-02-15T17:17:01Z

tor-netdoc: Remove many needless calls to .iter() and .into_iter()

2023-02-15T17:17:01Z

netdoc: Add a feature to expose hsdesc inner doc parsers

2023-02-14T12:44:18Z

We want to fuzz these parsers, but there's no currently way to get at the parsers for inner documents without going through a lot of encryption. (Coverage-guided fuzzers are powerful, but they can't find SHA3 preimages.)

batching_split_before: Rename "prefix" to "header"

2023-02-13T16:55:36Z

As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1016#note_2877759 "_prefixed" becomes "_with_header". That mirrors the returned struct which is nice.

tor-netdoc: Use batching_split_before in HsDescInner

2023-02-10T19:47:45Z

netdoc: Fix most "TODO HS rename" comments

2023-02-08T18:23:21Z

netdoc::hsdesc: Distinguish layer from document.

2023-02-08T18:16:44Z