mirrors/arti.git/crates/tor-netdoc/src/doc/hsdesc/build.rs, branch arti-v1.1.5

netdoc, hsclient: Update remaining ed25519::SecretKey users

2023-05-18T18:18:53Z

Fortunately, these are all in experimental code. Closes #798

Use non-deprecated *Secret::random_from_rng.

2023-05-13T20:52:23Z

The `new` function is deprecated in x25519-dalek 2.0.0-rc.2

Generate a new KP_hss_desc_enc keypair for each new descriptor.

2023-03-31T14:04:30Z

Previously, to build descriptors for hidden services with client auth enabled, in addition to the list of authorized clients, users of `HsDescBuilder` were required to also provide a descriptor encryption keypair and a descriptor cookie. This was potentially dangerous and/or error-prone, because the ephemeral encryption key and the descriptor cookie are expected to be randomly generated and unique for each descriptor. This change makes `ClientAuth` private to the `hsdesc::build` module and updates `HsDescBuilder` to build `ClientAuth`s internally. Users now only need to provide the list of authorized client public keys. Signed-off-by: Gabriela Moldovan

Remove unnecessary test constant.

2023-03-31T14:04:26Z

It's not really needed, it can just be generated at (test) runtime. Signed-off-by: Gabriela Moldovan

Add an encode-decode test for descriptors with client auth.

2023-03-31T14:04:23Z

This adds a test for an `encode -> decode -> encode` flow for a hidden service descriptor with client authorization enabled. Signed-off-by: Gabriela Moldovan

Use constants instead of magic numbers.

2023-03-31T14:04:19Z

Signed-off-by: Gabriela Moldovan

Stop requiring the caller to supply `AuthClient`s.

2023-03-31T14:04:15Z

`AuthClient`s were originally meant to represent parsed `auth-client` lines. In !1070, this struct was repurposed for representing individual authorized clients in the HS descriptor encoder. However, hidden services will likely use a list of public keys to represent the authorized clients rather than a list of `AuthClient`s, as the information from an `AuthClient` (`client_id`, `iv`, `encrypted_cookie`) likely won't be immediately available to the hidden service. This change updates the HS descriptor encoder to represent authorized clients as a list of `curve25519::PublicKey`s. As such, it is now the responsibility of the encoder to create the `client_id`, `iv`, and `encrypted_cookie` using the available keys, the unencrypted descriptor cookie, and HS subcredential. Signed-off-by: Gabriela Moldovan

Remove hard-coded test certs.

2023-03-27T18:44:49Z

We can use a deterministic rng to generate predictable keypairs instead. Signed-off-by: Gabriela Moldovan

Make the HS encoder randomness source injectable.

2023-03-27T18:07:41Z

This makes it possible to plug in a deterministic randomness source for testing. Signed-off-by: Gabriela Moldovan

Use the type system to enforce use of blinded keys.

2023-03-27T10:45:51Z

Hidden services use blinded singing keys derived from the identity key to sign descriptor signing keys. Before this patch, the hidden descriptor builder represented its blinded signing keys (`blinded_id`) as plain `ed25519::Keypair`s. This was not ideal, as there was nothing preventing the caller from accidentally initializing `blinded_id` with an unblinded keypair. This introduces a new `HsBlindKeypair` type to represent blinded keypairs. Signed-off-by: Gabriela Moldovan