mirrors/arti.git/crates/tor-netdoc/src/doc/hsdesc/build.rs, branch arti-v1.1.3

Remove hard-coded test certs.

2023-03-27T18:44:49Z

We can use a deterministic rng to generate predictable keypairs instead. Signed-off-by: Gabriela Moldovan

Make the HS encoder randomness source injectable.

2023-03-27T18:07:41Z

This makes it possible to plug in a deterministic randomness source for testing. Signed-off-by: Gabriela Moldovan

Use the type system to enforce use of blinded keys.

2023-03-27T10:45:51Z

Hidden services use blinded singing keys derived from the identity key to sign descriptor signing keys. Before this patch, the hidden descriptor builder represented its blinded signing keys (`blinded_id`) as plain `ed25519::Keypair`s. This was not ideal, as there was nothing preventing the caller from accidentally initializing `blinded_id` with an unblinded keypair. This introduces a new `HsBlindKeypair` type to represent blinded keypairs. Signed-off-by: Gabriela Moldovan

Use transparent structs instead of builders.

2023-03-24T18:58:34Z

The consensus seems to be the builders don't add much value, see [this comment]. [this comment]: https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1070#note_2889488 Signed-off-by: Gabriela Moldovan

Remove `NetdocText` and replace its uses with `String`.

2023-03-24T18:58:34Z

`NetdocText` is a wrapper around a `String` and a type marker. The type annotation proved of limited use, and made the netdoc builder API somewhat awkward to use. Signed-off-by: Gabriela Moldovan

Create a new `IntroPointDesc` type.

2023-03-24T18:58:33Z

Unlike `hsdesc::IntroPointDesc`, `hsdesc::build::IntroPointDesc` represents link specifiers as `LinkSpec`s rather than `UnparsedLinkSpec`s. Since this is a general-purpose representation of an introduction point and not merely an intermediate representation for decoding/encoding, it will probably need to be factored out of `tor-netdoc` at some point. Signed-off-by: Gabriela Moldovan

Use the less ambiguous inner/middle/outer terminology.

2023-03-24T18:57:53Z

Add builder for encoding hidden service descriptors.

2023-03-24T18:57:49Z

This introduces the `NetdocBuilder` trait described in `netdoc-builder.md` and a new `tor-netdoc::doc::hsdesc::build` module, which exports the `HsDescBuilder`. Hidden services will use `HsDescBuilder` to build and encode hidden service descriptors. There are several TODOs in the code that I'm planning to address separately. Partially addresses #745. Signed-off-by: Gabriela Moldovan