mirrors/arti.git/crates/tor-netdoc/src/doc/authcert, branch main mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=main 2026-06-22T14:27:48Z tor-netdoc: embedded auth certs: Use real vote type, not poc (fmt) 2026-06-22T14:27:48Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-06-16T10:01:54Z urn:sha1:e1e1efc4b771b65e24ac73e2fbb12ec2fe618576 tor-netdoc: embedded auth certs: Use real vote type, not poc 2026-06-22T14:27:48Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-06-15T12:09:48Z urn:sha1:f3e3c47b71081155952d31adaa29e094a17f9657 tor-netdoc: fix EncodedAuthCert parsing 2026-06-15T12:06:32Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-06-15T11:18:35Z urn:sha1:f6f23812fd77058c843c2441cda73bf4902346fa It would swallow the whole rest of the document, leading to bizarre output on re-encoding. There is no test case for this in-tree (which is why this is cfg "incomplete"), but I have a full roundtrip test of a vote (which contains an authcert) in a wip branch, which detected this problem. maint: Run maint/add_warning to deny string slices 2026-06-09T15:36:01Z Clara Engler cve@cve.cx 2026-06-09T15:36:01Z urn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97 This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit. tor-netdoc: Gate vote-related incomplete code with "incomplete" (fmt) 2026-04-28T14:56:25Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-28T14:56:25Z urn:sha1:a487c3f0b7eeee32c61e5306bfb6312364bbef9d tor-netdoc: Gate vote-related incomplete code with "incomplete" (tidy) 2026-04-28T14:56:19Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-28T14:54:54Z urn:sha1:4d4220e8a0fab3f1210a54ce1d3230b39ae7a89b tor-netdoc: Gate vote-related incomplete code with "incomplete" 2026-04-28T13:58:19Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-28T13:41:40Z urn:sha1:f5aef395d597e877464125e26399ed94ac2ba540 Change "ns-vote" gates to "incomplete": * `vote` modules, and in the variety macro. (And make a TODO more likely to be found.) Change "parse2" gates to "incomplete": * VoteAuthoritySection tor-netdoc: EncodedAuthCert: implement NetdocEncodable 2026-04-27T15:48:37Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-04-14T18:56:27Z urn:sha1:ff584cc98541a00f9dfde0f129b2c5373197fd28 tor-netdoc: Port to web-time-compat 2026-03-26T19:20:16Z Nick Mathewson nickm@torproject.org 2026-03-26T14:39:48Z urn:sha1:cec5d8e8194a03ace7e45ebbeba95a7da0c3f7cb tor-netdoc: parse2: Don't impl NetdocParseable for bodies of signed docs 2026-03-19T10:37:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-03-11T12:24:55Z urn:sha1:5e5dc10f0f4d477bf0e8e4d2197610c149a59541 Such an impl is a footgun. Explain this in docs & comments.