mirrors/arti.git/crates/tor-netdoc/src/doc/authcert.rs, branch mainmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=main2026-07-23T17:24:20Ztor-netdoc: Use encode_netdoc_unsigned in several places2026-07-23T17:24:20ZIan Jacksonijackson@chiark.greenend.org.uk2026-07-23T16:06:26Zurn:sha1:523d395bd8f18a9c42229a0017136fbda6fecc31tor-checkable: Rename `TimeBound::check_valid_*` to `if_valid_*`2026-07-23T10:13:34ZIan Jacksonijackson@chiark.greenend.org.uk2026-07-20T16:40:18Zurn:sha1:ca37f30a097696ce2ebd4e9945a4bdaebe086b31
I find these names confusing. To my mind "check" implies a function
returning `Result<(), _>`.
Some other APIs use `unwrap` here but I think `if` is good.
tor-checkable: TimeRangeBound: Rename extend_tolerance to extend_end_bound2026-07-23T10:13:34ZIan Jacksonijackson@chiark.greenend.org.uk2026-07-20T14:28:04Zurn:sha1:7ce9f5c34c3bdb95e87dac5c8348f6937256c5f5
It was confusing that one of these functions had "which bound"
mentioned in its name, but the other didn't. So add `end` and switch
from `tolerance` to `bound` (see previous commit message).
*This* commit should deal only in `extend_tolerance` and `end` and
shouldn't touch `extend_start_bound` or `extend_pre_tolerance`.
tor-checkable: TimeRangeBound: Rename extend_pre_tolerance to extend_start_bound2026-07-23T10:13:34ZIan Jacksonijackson@chiark.greenend.org.uk2026-07-20T10:09:16Zurn:sha1:306fffc11215201aa1b5d6baf84f985bb3fee1bf
Although it is often used to apply a tolerance, it doesn't make sense
to say that this is extending the "tolerance" of a `TimeRangeBound`.
A `TimeRangeBound` doesn't have a tolerance, only bounds.
Also we should be consistent in our terminology, and use `start`
rather than `pre`.
We'll rename the other method too. Doing them one at a time will
makes it easier to spot any "pre/start" vs "<nothing>/end" slips:
*this* commit should deal only in `pre` and `start` and shouldn't
touch `extend_tolerance`.
Use new TimeRangeBound name throughout the tree2026-07-16T15:47:50ZIan Jacksonijackson@chiark.greenend.org.uk2026-07-16T14:35:45Zurn:sha1:92c26c4c07be73c91890ed3d7d4e53a06f26d0a1Use new TimeBound name throughout the tree2026-07-16T15:47:50ZIan Jacksonijackson@chiark.greenend.org.uk2026-07-16T14:32:14Zurn:sha1:5f57903ab4a8c280acf8a5bec274c50d5f544fd6tor-netdoc: Stabilise votes and encoding of authcerts2026-07-15T12:00:00ZIan Jacksonijackson@chiark.greenend.org.uk2026-07-01T11:48:08Zurn:sha1:8638e53554781002cfef27dad8f879a0ee4cb289tor-netdoc: Replace string slices with str::get() in doc (fmt)2026-06-24T12:24:30ZClara Englercve@cve.cx2026-06-24T12:24:30Zurn:sha1:648117f59cd083736d7055e2399d87034bd47f11
No functional change, just reformatting.
tor-netdoc: Replace string slices with str::get() in doc2026-06-24T12:22:30ZClara Englercve@cve.cx2026-06-24T12:22:30Zurn:sha1:9587e70a6f8155f15dc454a1d70d14d1fd774382
This commit replaces the use of string slices with str::get() in all
document related code.
While this is not a perfect replacement for it, the relevant parts in
the code heavily depend upon the byte offsets returned by the low level
(legacy) parser where changing it would lead to a very big refactoring.
Nonetheless, this approach is better because returning a bug is better
than crashing.
tor-netdoc: tests: Move poc authcert test to authcert.rs2026-06-17T09:33:17ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-11T14:42:42Zurn:sha1:48aba6978c538ef4c16b9f2febc87223b8097b12
There is no separate poc authcert type any more. This is a perfectly
fine test case.
Almost entirely code motion; review with
git show --color-moved --color-moved-ws=allow-indentation-change