mirrors/arti.git/crates/tor-netdoc/src/doc/authcert.rs, branch arti-v2.5.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.02026-06-24T12:24:30Ztor-netdoc: Replace string slices with str::get() in doc (fmt)2026-06-24T12:24:30ZClara Englercve@cve.cx2026-06-24T12:24:30Zurn:sha1:648117f59cd083736d7055e2399d87034bd47f11
No functional change, just reformatting.
tor-netdoc: Replace string slices with str::get() in doc2026-06-24T12:22:30ZClara Englercve@cve.cx2026-06-24T12:22:30Zurn:sha1:9587e70a6f8155f15dc454a1d70d14d1fd774382
This commit replaces the use of string slices with str::get() in all
document related code.
While this is not a perfect replacement for it, the relevant parts in
the code heavily depend upon the byte offsets returned by the low level
(legacy) parser where changing it would lead to a very big refactoring.
Nonetheless, this approach is better because returning a bug is better
than crashing.
tor-netdoc: tests: Move poc authcert test to authcert.rs2026-06-17T09:33:17ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-11T14:42:42Zurn:sha1:48aba6978c538ef4c16b9f2febc87223b8097b12
There is no separate poc authcert type any more. This is a perfectly
fine test case.
Almost entirely code motion; review with
git show --color-moved --color-moved-ws=allow-indentation-change
tor-netdoc: Use assert_eq_or_diff in three more places2026-06-11T11:38:51ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-11T11:31:31Zurn:sha1:d40b0d15e3315292948cf0ceeb8127ff2e14670ftor-netdoc: authcert: use TimerangeBound for UnverifiedAuthCert::verify (fmt)2026-06-10T14:42:10ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-04T12:13:00Zurn:sha1:b6e5b60f02eb6c523a42ee3bc726b8dc6a8b94b0
Precisely the result of rustfmt.
tor-netdoc: authcert: use TimerangeBound for UnverifiedAuthCert::verify2026-06-10T14:42:10ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-04T12:10:18Zurn:sha1:ccac99474f98ef197a7dfc48930c2c67662e7991
TimerangeBound is reasonably nice and this will fit in better when we
want to verify votes.
Adjust the one non-test call site (in tor-dirserver) using .and_then.
In the tests:
* Where we expected success, call .check_valid_at and add another .unwrap().
* Where we expected signature verification failure, delete the time parameters.
* Where we expected timeliness failure, call .check_valid_at and map the error.
* With nontrivial tolerance, add calls to `extend_[pre_]tolerance`.
tor-netdoc: authcert tests: add some parentheses2026-06-10T14:41:46ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-04T12:10:14Zurn:sha1:9257037726c831326c2b3cfe2feda003482482eetor-netdoc: authcert tests: insist on return value type2026-06-10T14:41:46ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-04T12:09:19Zurn:sha1:4bc868daac9504853c1b66529c5c884956e085f9
We're about to make UnverifiedAuthCert::verify return a
TimerangeBound, not an AuthCert.
For the success cases, declare the expected return type.
everywhere: Add #[allow(clippy::string_slice)]2026-06-09T16:02:36ZClara Englercve@cve.cx2026-06-09T16:00:38Zurn:sha1:d0af4abbd7b371f1eade609202a730cd9a1c21d3
This commit adds #[allow(clippy::string_slice)] to all functions in the
code where string slices are used, alongside a TODO comment.
We do this add the function header to have it consistent, as things like
expression based allow's are still experimental.
maint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.