mirrors/arti.git/crates/tor-netdir/src, branch arti-v1.2.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.02024-02-20T14:37:00ZNote a calculation we can clean up after doing spec work.2024-02-20T14:37:00ZNick Mathewsonnickm@torproject.org2024-02-13T14:19:08Zurn:sha1:35acbc0de8481ded920c289fb79bcaef07e481bfAdd caveats on is_flagged_guard, and note possible deprecation2024-02-20T14:37:00ZNick Mathewsonnickm@torproject.org2024-02-13T14:18:22Zurn:sha1:1631fac7ee69063e3ec6cceb8fe9338114c05185Add and use "UncheckedRelay::is_suitable_as_guard"2024-02-20T14:37:00ZNick Mathewsonnickm@torproject.org2024-02-13T14:16:53Zurn:sha1:7d0178352864409e7aa6b7b986d4e6d77fbe5357Only pick Fast relays as introduction points.2024-02-20T14:37:00ZNick Mathewsonnickm@torproject.org2024-02-12T15:43:24Zurn:sha1:9522cfe729dcf4a41f487e08d2b28c10d3a05d86
This matches the behavior of C tor. Part of #1100.
Require that guards are Fast and Stable.2024-02-20T14:37:00ZNick Mathewsonnickm@torproject.org2024-02-12T15:30:39Zurn:sha1:f20669fe460332b8656421d4f331f4287b754dd7
This matches the behavior of C tor.
Part of #1100.
netdir: Add Relay::is_flagged_{fast,stable} methods.2024-02-12T15:29:39ZNick Mathewsonnickm@torproject.org2024-02-12T15:22:26Zurn:sha1:ea3b4c663ca6963738a4fb6e3592188a72f57de8Rename parameters for intro-point lifetime to match the spec.2024-01-31T15:10:36ZNick Mathewsonnickm@torproject.org2024-01-31T15:10:36Zurn:sha1:4700e9ce6c075851068fd7ba17324b3d787ff651
(Also, correct the comments that describe them.)
We may as well match the spec names when they aren't completely
bogus.
We are already renaming these parameters for this release, so it
isn't an additional breaking change.
Rename our aliases for hs_intro_*_lifetime.2024-01-25T16:17:05ZNick Mathewsonnickm@torproject.org2024-01-25T16:17:05Zurn:sha1:829a9244a964894b7bd1bebf298a688a7ee8f513
The old names were somewhat inaccurate. (I would have considered
keeping and deprecating the old names, but we already have breaking
changes in tor-netdir.)
tor-netdir: Add a unit test for HsDirParams::offset_within_srv_period.2024-01-24T16:42:43ZGabriela Moldovangabi@torproject.org2024-01-24T16:42:43Zurn:sha1:14445e8bb0f3daa9420a3330614eeb4874bf881dtor-hsservice: Make offset_within_srv_period() work with timestamps from newer periods.2024-01-24T15:58:55ZGabriela Moldovangabi@torproject.org2024-01-24T15:51:31Zurn:sha1:5050e8c367ba0fb09552d93d3878a193f45678f2
This fixes a bug where `offset_within_srv_period()` returns `None`,
instead of the offset of `when` from the start of the SRV of the
previous time period:
```
2024-01-24T15:24:46Z ERROR tor_hsservice::svc::publish::reactor: descriptor upload failed for HS service
allium-cepa2 and time period TimePeriod { interval_num: 19745, length: IntegerMinutes { value: 1440 },
epoch_offset_in_sec: 43200 }: error: Programming error: internal error (bug) at
/../arti/crates/tor-hsservice/src/svc/publish/reactor.rs:218:13: current wallclock time not within
SRV range?! (now=SystemTime { tv_sec: 1706109886, tv_nsec: 246572852 },
SRV_start=SystemTime { tv_sec: 1705968000, tv_nsec: 0 })
```
We need to be able to calculate this offset even if `now` is not within
the SRV range (because we upload the descriptor to the HsDirs of the
*previous* time period too).
Note a similar bug exited in `offset_within_period()` (which no longer
exists) too! That one was fixed in !1744:
```
Hidden services can have multiple "active" time periods for which they
generate descriptors. We need to be able to compute the offset of a
timestamp from the start of a given time period, even if that timestamp
falls within the "next" time period (for example, when publishing
descriptors for the "previous" time period, the `when` timestamp will
fall outside the `(start, end)` range of the "previous" time period).
```